afs: Fix bulk lookup malfunction due to change in dir_emit() API

afs_do_lookup() and afs_do_lookup_one() use the same directory parsing code
as afs_readdir() and were supplying alternative dir_context actors to
retrieve dirents, but because lookup needs the vnode's uniquifier as part
of the reference, but not the DT flags, the uniquifier was being passed in
the dt flags argument to the lookup actors.

Unfortunately, commit c644bce62b9c, added to fix overlayfs with fuse, broke
this by masking off part of the uniquifier.  This doesn't matter enough to
be directly noticeable, instead causing bulk advance inode lookups to fail
(which are retried later) and may cause dir revalidation to malfunction if
the uniquifier is changed by masking.

Fix this by making the afs directory parsing code take special ->actor
values of AFS_LOOKUP or AFS_LOOKUP_ONE instead that tell it to call
afs_lookup_filldir() or afs_lookup_one_filldir() directly rather than going
through dir_emit().  dir_emit() is still used for readdir.

Fixes: c644bce62b9c ("readdir: require opt-in for d_type flags")
Reported-by: Marc Dionne <marc.dionne@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://patch.msgid.link/20260622090856.2746629-11-dhowells@redhat.com
cc: Amir Goldstein <amir73il@gmail.com>
cc: linux-afs@lists.infradead.org
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>

diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index 498b99ccdf0e2786999cd5f8e902a086312cf689..6df56fe9163fd72eb2ba901b6bdedbd80655983c 100644 (file)
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -28,9 +28,11 @@ static int afs_d_revalidate(struct inode *dir, const struct qstr *name,
 static int afs_d_delete(const struct dentry *dentry);
 static void afs_d_iput(struct dentry *dentry, struct inode *inode);
 static bool afs_lookup_one_filldir(struct dir_context *ctx, const char *name, int nlen,
-                                 loff_t fpos, u64 ino, unsigned dtype);
+                                  u64 ino, u32 uniquifier);
+#define AFS_LOOKUP_ONE ((filldir_t)0x123UL)
 static bool afs_lookup_filldir(struct dir_context *ctx, const char *name, int nlen,
-                             loff_t fpos, u64 ino, unsigned dtype);
+                              u64 ino, u32 uniquifier);
+#define AFS_LOOKUP ((filldir_t)0x137UL)
 static int afs_create(struct mnt_idmap *idmap, struct inode *dir,
                      struct dentry *dentry, umode_t mode, bool excl);
 static struct dentry *afs_mkdir(struct mnt_idmap *idmap, struct inode *dir,
@@ -421,11 +423,18 @@ static int afs_dir_iterate_block(struct afs_vnode *dvnode,
                }
 
                /* found the next entry */
-               if (!dir_emit(ctx, dire->u.name, nlen,
-                             ntohl(dire->u.vnode),
-                             (ctx->actor == afs_lookup_filldir ||
-                              ctx->actor == afs_lookup_one_filldir)?
-                             ntohl(dire->u.unique) : DT_UNKNOWN)) {
+               if (ctx->actor == AFS_LOOKUP) {
+                       if (!afs_lookup_filldir(ctx, dire->u.name, nlen,
+                                               ntohl(dire->u.vnode),
+                                               ntohl(dire->u.unique)))
+                               return 0;
+               } else if (ctx->actor == AFS_LOOKUP_ONE) {
+                       if (!afs_lookup_one_filldir(ctx, dire->u.name, nlen,
+                                                   ntohl(dire->u.vnode),
+                                                   ntohl(dire->u.unique)))
+                               return 0;
+               } else if (!dir_emit(ctx, dire->u.name, nlen,
+                                    ntohl(dire->u.vnode), DT_UNKNOWN)) {
                        _leave(" = 0 [full]");
                        return 0;
                }
@@ -545,6 +554,7 @@ static int afs_readdir(struct file *file, struct dir_context *ctx)
 {
        afs_dataversion_t dir_version;
 
+       ctx->dt_flags_mask = UINT_MAX;
        return afs_dir_iterate(file_inode(file), ctx, file, &dir_version);
 }
 
@@ -554,14 +564,14 @@ static int afs_readdir(struct file *file, struct dir_context *ctx)
  *   uniquifier through dtype
  */
 static bool afs_lookup_one_filldir(struct dir_context *ctx, const char *name,
-                                 int nlen, loff_t fpos, u64 ino, unsigned dtype)
+                                 int nlen, u64 ino, u32 uniquifier)
 {
        struct afs_lookup_one_cookie *cookie =
                container_of(ctx, struct afs_lookup_one_cookie, ctx);
 
        _enter("{%s,%u},%s,%u,,%llu,%u",
               cookie->name.name, cookie->name.len, name, nlen,
-              (unsigned long long) ino, dtype);
+              (unsigned long long) ino, uniquifier);
 
        /* insanity checks first */
        BUILD_BUG_ON(sizeof(union afs_xdr_dir_block) != 2048);
@@ -574,7 +584,7 @@ static bool afs_lookup_one_filldir(struct dir_context *ctx, const char *name,
        }
 
        cookie->fid.vnode = ino;
-       cookie->fid.unique = dtype;
+       cookie->fid.unique = uniquifier;
        cookie->found = 1;
 
        _leave(" = false [found]");
@@ -591,7 +601,7 @@ static int afs_do_lookup_one(struct inode *dir, const struct qstr *name,
 {
        struct afs_super_info *as = dir->i_sb->s_fs_info;
        struct afs_lookup_one_cookie cookie = {
-               .ctx.actor = afs_lookup_one_filldir,
+               .ctx.actor = AFS_LOOKUP_ONE,
                .name = *name,
                .fid.vid = as->volume->vid
        };
@@ -622,14 +632,14 @@ static int afs_do_lookup_one(struct inode *dir, const struct qstr *name,
  *   uniquifier through dtype
  */
 static bool afs_lookup_filldir(struct dir_context *ctx, const char *name,
-                             int nlen, loff_t fpos, u64 ino, unsigned dtype)
+                             int nlen, u64 ino, u32 uniquifier)
 {
        struct afs_lookup_cookie *cookie =
                container_of(ctx, struct afs_lookup_cookie, ctx);
 
        _enter("{%s,%u},%s,%u,,%llu,%u",
               cookie->name.name, cookie->name.len, name, nlen,
-              (unsigned long long) ino, dtype);
+              (unsigned long long) ino, uniquifier);
 
        /* insanity checks first */
        BUILD_BUG_ON(sizeof(union afs_xdr_dir_block) != 2048);
@@ -637,7 +647,7 @@ static bool afs_lookup_filldir(struct dir_context *ctx, const char *name,
 
        if (cookie->nr_fids < 50) {
                cookie->fids[cookie->nr_fids].vnode     = ino;
-               cookie->fids[cookie->nr_fids].unique    = dtype;
+               cookie->fids[cookie->nr_fids].unique    = uniquifier;
                cookie->nr_fids++;
        }
 
@@ -778,7 +788,7 @@ static struct inode *afs_do_lookup(struct inode *dir, struct dentry *dentry)
 
        for (i = 0; i < ARRAY_SIZE(cookie->fids); i++)
                cookie->fids[i].vid = dvnode->fid.vid;
-       cookie->ctx.actor = afs_lookup_filldir;
+       cookie->ctx.actor = AFS_LOOKUP;
        cookie->name = dentry->d_name;
        cookie->nr_fids = 2; /* slot 1 is saved for the fid we actually want
                              * and slot 0 for the directory */