]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/vkms: Add missing check for CRTC initialization
authorLouis Chauvet <louis.chauvet@bootlin.com>
Fri, 6 Sep 2024 16:15:03 +0000 (18:15 +0200)
committerMaíra Canal <mcanal@igalia.com>
Tue, 24 Sep 2024 23:44:59 +0000 (20:44 -0300)
CRTC initialization call drm_mode_crtc_set_gamma_size without the proper
checks, introduce this check to avoid issues.

Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
Reviewed-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240906-vkms-add-missing-check-v1-1-1afb3bf3d0a6@bootlin.com
drivers/gpu/drm/vkms/vkms_crtc.c

index 2ad164b518fb93f5b6b86948116ff7ed97770b60..a40295c18b485953dc5d97ef5b0c687ccd2c0756 100644 (file)
@@ -289,7 +289,12 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc,
 
        drm_crtc_helper_add(crtc, &vkms_crtc_helper_funcs);
 
-       drm_mode_crtc_set_gamma_size(crtc, VKMS_LUT_SIZE);
+       ret = drm_mode_crtc_set_gamma_size(crtc, VKMS_LUT_SIZE);
+       if (ret) {
+               DRM_ERROR("Failed to set gamma size\n");
+               return ret;
+       }
+
        drm_crtc_enable_color_mgmt(crtc, 0, false, VKMS_LUT_SIZE);
 
        spin_lock_init(&vkms_out->lock);