]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs: replace shouty XFS_BM{BT,DR} macros
authorDarrick J. Wong <djwong@kernel.org>
Mon, 21 Oct 2024 00:10:44 +0000 (17:10 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 31 Oct 2024 22:45:03 +0000 (15:45 -0700)
Source kernel commit: 79124b3740063573312de4b225407ebdae219275

Replace all the shouty bmap btree and bmap disk root macros with actual
functions.

sed \
-e 's/XFS_BMBT_BLOCK_LEN/xfs_bmbt_block_len/g' \
-e 's/XFS_BMBT_REC_ADDR/xfs_bmbt_rec_addr/g' \
-e 's/XFS_BMBT_KEY_ADDR/xfs_bmbt_key_addr/g' \
-e 's/XFS_BMBT_PTR_ADDR/xfs_bmbt_ptr_addr/g' \
-e 's/XFS_BMDR_REC_ADDR/xfs_bmdr_rec_addr/g' \
-e 's/XFS_BMDR_KEY_ADDR/xfs_bmdr_key_addr/g' \
-e 's/XFS_BMDR_PTR_ADDR/xfs_bmdr_ptr_addr/g' \
-e 's/XFS_BMAP_BROOT_PTR_ADDR/xfs_bmap_broot_ptr_addr/g' \
-e 's/XFS_BMAP_BROOT_SPACE_CALC/xfs_bmap_broot_space_calc/g' \
-e 's/XFS_BMAP_BROOT_SPACE/xfs_bmap_broot_space/g' \
-e 's/XFS_BMDR_SPACE_CALC/xfs_bmdr_space_calc/g' \
-e 's/XFS_BMAP_BMDR_SPACE/xfs_bmap_bmdr_space/g' \
-i $(git ls-files fs/xfs/*.[ch] fs/xfs/libxfs/*.[ch] fs/xfs/scrub/*.[ch])

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
16 files changed:
db/bmap.c
db/bmap_inflate.c
db/bmroot.c
db/check.c
db/frag.c
db/metadump.c
libxfs/xfs_attr_leaf.c
libxfs/xfs_bmap.c
libxfs/xfs_bmap_btree.c
libxfs/xfs_bmap_btree.h
libxfs/xfs_inode_fork.c
libxfs/xfs_trans_resv.c
repair/bmap_repair.c
repair/dinode.c
repair/prefetch.c
repair/scan.c

index 874135f001ea00d3f27a0fde3a7d7559e2a9a7ac..7915772aaee4e03f14bfe57db5fd1f6ddf528940 100644 (file)
--- a/db/bmap.c
+++ b/db/bmap.c
@@ -78,8 +78,8 @@ bmap(
                push_cur();
                rblock = (xfs_bmdr_block_t *)XFS_DFORK_PTR(dip, whichfork);
                fsize = XFS_DFORK_SIZE(dip, mp, whichfork);
-               pp = XFS_BMDR_PTR_ADDR(rblock, 1, libxfs_bmdr_maxrecs(fsize, 0));
-               kp = XFS_BMDR_KEY_ADDR(rblock, 1);
+               pp = xfs_bmdr_ptr_addr(rblock, 1, libxfs_bmdr_maxrecs(fsize, 0));
+               kp = xfs_bmdr_key_addr(rblock, 1);
                bno = select_child(curoffset, kp, pp,
                                        be16_to_cpu(rblock->bb_numrecs));
                for (;;) {
@@ -88,9 +88,9 @@ bmap(
                        block = (struct xfs_btree_block *)iocur_top->data;
                        if (be16_to_cpu(block->bb_level) == 0)
                                break;
-                       pp = XFS_BMBT_PTR_ADDR(mp, block, 1,
+                       pp = xfs_bmbt_ptr_addr(mp, block, 1,
                                libxfs_bmbt_maxrecs(mp, mp->m_sb.sb_blocksize, 0));
-                       kp = XFS_BMBT_KEY_ADDR(mp, block, 1);
+                       kp = xfs_bmbt_key_addr(mp, block, 1);
                        bno = select_child(curoffset, kp, pp,
                                        be16_to_cpu(block->bb_numrecs));
                }
@@ -98,7 +98,7 @@ bmap(
                        nextbno = be64_to_cpu(block->bb_u.l.bb_rightsib);
                        nextents = be16_to_cpu(block->bb_numrecs);
                        xp = (xfs_bmbt_rec_t *)
-                               XFS_BMBT_REC_ADDR(mp, block, 1);
+                               xfs_bmbt_rec_addr(mp, block, 1);
                        for (ep = xp; ep < &xp[nextents] && n < nex; ep++) {
                                if (!bmap_one_extent(ep, &curoffset, eoffset,
                                                &n, bep)) {
index 4de534dccf34b2368bd970003038a93383805d97..1de6d3439ab3d3490d4933c1c587c8767ce6e195 100644 (file)
@@ -269,7 +269,7 @@ iroot_size(
        unsigned int            nr_this_level,
        void                    *priv)
 {
-       return XFS_BMAP_BROOT_SPACE_CALC(cur->bc_mp, nr_this_level);
+       return xfs_bmap_broot_space_calc(cur->bc_mp, nr_this_level);
 }
 
 static int
index 246e390a8a39e788131ac9cac816f324b13c70fe..7ef07da181e6ff72684714954675bcf3ca47c3ae 100644 (file)
@@ -89,7 +89,7 @@ bmroota_key_offset(
        block = (xfs_bmdr_block_t *)((char *)obj + byteize(startoff));
        ASSERT(dip->di_forkoff != 0 && (char *)block == XFS_DFORK_APTR(dip));
        ASSERT(be16_to_cpu(block->bb_level) > 0);
-       kp = XFS_BMDR_KEY_ADDR(block, idx);
+       kp = xfs_bmdr_key_addr(block, idx);
        return bitize((int)((char *)kp - (char *)block));
 }
 
@@ -127,7 +127,7 @@ bmroota_ptr_offset(
        block = (xfs_bmdr_block_t *)((char *)obj + byteize(startoff));
        ASSERT(dip->di_forkoff != 0 && (char *)block == XFS_DFORK_APTR(dip));
        ASSERT(be16_to_cpu(block->bb_level) > 0);
-       pp = XFS_BMDR_PTR_ADDR(block, idx,
+       pp = xfs_bmdr_ptr_addr(block, idx,
                libxfs_bmdr_maxrecs(XFS_DFORK_ASIZE(dip, mp), 0));
        return bitize((int)((char *)pp - (char *)block));
 }
@@ -185,7 +185,7 @@ bmrootd_key_offset(
        ASSERT(obj == iocur_top->data);
        block = (xfs_bmdr_block_t *)((char *)obj + byteize(startoff));
        ASSERT(be16_to_cpu(block->bb_level) > 0);
-       kp = XFS_BMDR_KEY_ADDR(block, idx);
+       kp = xfs_bmdr_key_addr(block, idx);
        return bitize((int)((char *)kp - (char *)block));
 }
 
@@ -222,7 +222,7 @@ bmrootd_ptr_offset(
        dip = obj;
        block = (xfs_bmdr_block_t *)((char *)obj + byteize(startoff));
        ASSERT(be16_to_cpu(block->bb_level) > 0);
-       pp = XFS_BMDR_PTR_ADDR(block, idx,
+       pp = xfs_bmdr_ptr_addr(block, idx,
                libxfs_bmdr_maxrecs(XFS_DFORK_DSIZE(dip, mp), 0));
        return bitize((int)((char *)pp - (char *)block));
 }
index 0e91fded0c423657a0149445680e6fa174490e22..0a6e5c3280e1cf8ac0d2677f90afbaedd7dbda64 100644 (file)
@@ -2321,13 +2321,13 @@ process_btinode(
                return;
        }
        if (be16_to_cpu(dib->bb_level) == 0) {
-               xfs_bmbt_rec_t  *rp = XFS_BMDR_REC_ADDR(dib, 1);
+               xfs_bmbt_rec_t  *rp = xfs_bmdr_rec_addr(dib, 1);
                process_bmbt_reclist(rp, be16_to_cpu(dib->bb_numrecs), type,
                                                        id, totd, blkmapp);
                *nex += be16_to_cpu(dib->bb_numrecs);
                return;
        } else {
-               pp = XFS_BMDR_PTR_ADDR(dib, 1, libxfs_bmdr_maxrecs(
+               pp = xfs_bmdr_ptr_addr(dib, 1, libxfs_bmdr_maxrecs(
                                XFS_DFORK_SIZE(dip, mp, whichfork), 0));
                for (i = 0; i < be16_to_cpu(dib->bb_numrecs); i++)
                        scan_lbtree(get_unaligned_be64(&pp[i]),
@@ -4357,7 +4357,7 @@ scanfunc_bmap(
                        error++;
                        return;
                }
-               rp = XFS_BMBT_REC_ADDR(mp, block, 1);
+               rp = xfs_bmbt_rec_addr(mp, block, 1);
                *nex += be16_to_cpu(block->bb_numrecs);
                process_bmbt_reclist(rp, be16_to_cpu(block->bb_numrecs), type, id, totd,
                        blkmapp);
@@ -4373,7 +4373,7 @@ scanfunc_bmap(
                error++;
                return;
        }
-       pp = XFS_BMBT_PTR_ADDR(mp, block, 1, mp->m_bmap_dmxr[0]);
+       pp = xfs_bmbt_ptr_addr(mp, block, 1, mp->m_bmap_dmxr[0]);
        for (i = 0; i < be16_to_cpu(block->bb_numrecs); i++)
                scan_lbtree(be64_to_cpu(pp[i]), level, scanfunc_bmap, type, id,
                                        totd, toti, nex, blkmapp, 0, btype);
index 4efc6ad07f87522d1b5d5879d7ee76145d891859..1165e824a375e73793509528262ea5fb094c4f0d 100644 (file)
--- a/db/frag.c
+++ b/db/frag.c
@@ -243,11 +243,11 @@ process_btinode(
 
        dib = (xfs_bmdr_block_t *)XFS_DFORK_PTR(dip, whichfork);
        if (be16_to_cpu(dib->bb_level) == 0) {
-               xfs_bmbt_rec_t          *rp = XFS_BMDR_REC_ADDR(dib, 1);
+               xfs_bmbt_rec_t          *rp = xfs_bmdr_rec_addr(dib, 1);
                process_bmbt_reclist(rp, be16_to_cpu(dib->bb_numrecs), extmapp);
                return;
        }
-       pp = XFS_BMDR_PTR_ADDR(dib, 1,
+       pp = xfs_bmdr_ptr_addr(dib, 1,
                libxfs_bmdr_maxrecs(XFS_DFORK_SIZE(dip, mp, whichfork), 0));
        for (i = 0; i < be16_to_cpu(dib->bb_numrecs); i++)
                scan_lbtree(get_unaligned_be64(&pp[i]),
@@ -437,7 +437,7 @@ scanfunc_bmap(
                                   nrecs, typtab[btype].name);
                        return;
                }
-               rp = XFS_BMBT_REC_ADDR(mp, block, 1);
+               rp = xfs_bmbt_rec_addr(mp, block, 1);
                process_bmbt_reclist(rp, nrecs, extmapp);
                return;
        }
@@ -447,7 +447,7 @@ scanfunc_bmap(
                           nrecs, typtab[btype].name);
                return;
        }
-       pp = XFS_BMBT_PTR_ADDR(mp, block, 1, mp->m_bmap_dmxr[0]);
+       pp = xfs_bmbt_ptr_addr(mp, block, 1, mp->m_bmap_dmxr[0]);
        for (i = 0; i < nrecs; i++)
                scan_lbtree(be64_to_cpu(pp[i]), level, scanfunc_bmap, extmapp,
                                                                        btype);
index 424544f9f032240c7b019fa6827d18eff83d78ef..5c57c1293a53cb11eff15edb93c215d8697bfd99 100644 (file)
@@ -249,8 +249,8 @@ zero_btree_node(
                if (nrecs > mp->m_bmap_dmxr[1])
                        return;
 
-               bkp = XFS_BMBT_KEY_ADDR(mp, block, 1);
-               bpp = XFS_BMBT_PTR_ADDR(mp, block, 1, mp->m_bmap_dmxr[1]);
+               bkp = xfs_bmbt_key_addr(mp, block, 1);
+               bpp = xfs_bmbt_ptr_addr(mp, block, 1, mp->m_bmap_dmxr[1]);
                zp1 = (char *)&bkp[nrecs];
                zp2 = (char *)&bpp[nrecs];
                key_end = (char *)bpp;
@@ -315,7 +315,7 @@ zero_btree_leaf(
                if (nrecs > mp->m_bmap_dmxr[0])
                        return;
 
-               brp = XFS_BMBT_REC_ADDR(mp, block, 1);
+               brp = xfs_bmbt_rec_addr(mp, block, 1);
                zp = (char *)&brp[nrecs];
                break;
        case TYP_INOBT:
@@ -2113,7 +2113,7 @@ scanfunc_bmap(
                                        typtab[btype].name, agno, agbno);
                        return 1;
                }
-               return process_bmbt_reclist(XFS_BMBT_REC_ADDR(mp, block, 1),
+               return process_bmbt_reclist(xfs_bmbt_rec_addr(mp, block, 1),
                                            nrecs, *(typnm_t*)arg);
        }
 
@@ -2123,7 +2123,7 @@ scanfunc_bmap(
                                        nrecs, typtab[btype].name, agno, agbno);
                return 1;
        }
-       pp = XFS_BMBT_PTR_ADDR(mp, block, 1, mp->m_bmap_dmxr[1]);
+       pp = xfs_bmbt_ptr_addr(mp, block, 1, mp->m_bmap_dmxr[1]);
        for (i = 0; i < nrecs; i++) {
                xfs_agnumber_t  ag;
                xfs_agblock_t   bno;
@@ -2176,7 +2176,7 @@ process_btinode(
        }
 
        if (level == 0) {
-               return process_bmbt_reclist(XFS_BMDR_REC_ADDR(dib, 1),
+               return process_bmbt_reclist(xfs_bmdr_rec_addr(dib, 1),
                                            nrecs, itype);
        }
 
@@ -2189,13 +2189,13 @@ process_btinode(
                return 1;
        }
 
-       pp = XFS_BMDR_PTR_ADDR(dib, 1, maxrecs);
+       pp = xfs_bmdr_ptr_addr(dib, 1, maxrecs);
 
        if (metadump.zero_stale_data) {
                char    *top;
 
                /* Unused btree key space */
-               top = (char*)XFS_BMDR_KEY_ADDR(dib, nrecs + 1);
+               top = (char*)xfs_bmdr_key_addr(dib, nrecs + 1);
                memset(top, 0, (char*)pp - top);
 
                /* Unused btree ptr space */
index ce20d81a486988ec7b4c37e723af84979c491f3c..97b71b6500bdc93ff937bf4315a3bf2717d38b58 100644 (file)
@@ -683,7 +683,7 @@ xfs_attr_shortform_bytesfit(
                 */
                if (!dp->i_forkoff && dp->i_df.if_bytes >
                    xfs_default_attroffset(dp))
-                       dsize = XFS_BMDR_SPACE_CALC(MINDBTPTRS);
+                       dsize = xfs_bmdr_space_calc(MINDBTPTRS);
                break;
        case XFS_DINODE_FMT_BTREE:
                /*
@@ -697,7 +697,7 @@ xfs_attr_shortform_bytesfit(
                                return 0;
                        return dp->i_forkoff;
                }
-               dsize = XFS_BMAP_BROOT_SPACE(mp, dp->i_df.if_broot);
+               dsize = xfs_bmap_bmdr_space(dp->i_df.if_broot);
                break;
        }
 
@@ -705,11 +705,11 @@ xfs_attr_shortform_bytesfit(
         * A data fork btree root must have space for at least
         * MINDBTPTRS key/ptr pairs if the data fork is small or empty.
         */
-       minforkoff = max_t(int64_t, dsize, XFS_BMDR_SPACE_CALC(MINDBTPTRS));
+       minforkoff = max_t(int64_t, dsize, xfs_bmdr_space_calc(MINDBTPTRS));
        minforkoff = roundup(minforkoff, 8) >> 3;
 
        /* attr fork btree root can have at least this many key/ptr pairs */
-       maxforkoff = XFS_LITINO(mp) - XFS_BMDR_SPACE_CALC(MINABTPTRS);
+       maxforkoff = XFS_LITINO(mp) - xfs_bmdr_space_calc(MINABTPTRS);
        maxforkoff = maxforkoff >> 3;   /* rounded down */
 
        if (offset >= maxforkoff)
index e2267aa1a11d4eac338ba1d62a96aac728ab382f..a85a75da954c4e58ff3b33950a488716b53221c7 100644 (file)
@@ -73,9 +73,9 @@ xfs_bmap_compute_maxlevels(
        maxleafents = xfs_iext_max_nextents(xfs_has_large_extent_counts(mp),
                                whichfork);
        if (whichfork == XFS_DATA_FORK)
-               sz = XFS_BMDR_SPACE_CALC(MINDBTPTRS);
+               sz = xfs_bmdr_space_calc(MINDBTPTRS);
        else
-               sz = XFS_BMDR_SPACE_CALC(MINABTPTRS);
+               sz = xfs_bmdr_space_calc(MINABTPTRS);
 
        maxrootrecs = xfs_bmdr_maxrecs(sz, 0);
        minleafrecs = mp->m_bmap_dmnr[0];
@@ -96,8 +96,8 @@ xfs_bmap_compute_attr_offset(
        struct xfs_mount        *mp)
 {
        if (mp->m_sb.sb_inodesize == 256)
-               return XFS_LITINO(mp) - XFS_BMDR_SPACE_CALC(MINABTPTRS);
-       return XFS_BMDR_SPACE_CALC(6 * MINABTPTRS);
+               return XFS_LITINO(mp) - xfs_bmdr_space_calc(MINABTPTRS);
+       return xfs_bmdr_space_calc(6 * MINABTPTRS);
 }
 
 STATIC int                             /* error */
@@ -292,7 +292,7 @@ xfs_check_block(
        prevp = NULL;
        for( i = 1; i <= xfs_btree_get_numrecs(block); i++) {
                dmxr = mp->m_bmap_dmxr[0];
-               keyp = XFS_BMBT_KEY_ADDR(mp, block, i);
+               keyp = xfs_bmbt_key_addr(mp, block, i);
 
                if (prevp) {
                        ASSERT(be64_to_cpu(prevp->br_startoff) <
@@ -304,15 +304,15 @@ xfs_check_block(
                 * Compare the block numbers to see if there are dups.
                 */
                if (root)
-                       pp = XFS_BMAP_BROOT_PTR_ADDR(mp, block, i, sz);
+                       pp = xfs_bmap_broot_ptr_addr(mp, block, i, sz);
                else
-                       pp = XFS_BMBT_PTR_ADDR(mp, block, i, dmxr);
+                       pp = xfs_bmbt_ptr_addr(mp, block, i, dmxr);
 
                for (j = i+1; j <= be16_to_cpu(block->bb_numrecs); j++) {
                        if (root)
-                               thispa = XFS_BMAP_BROOT_PTR_ADDR(mp, block, j, sz);
+                               thispa = xfs_bmap_broot_ptr_addr(mp, block, j, sz);
                        else
-                               thispa = XFS_BMBT_PTR_ADDR(mp, block, j, dmxr);
+                               thispa = xfs_bmbt_ptr_addr(mp, block, j, dmxr);
                        if (*thispa == *pp) {
                                xfs_warn(mp, "%s: thispa(%d) == pp(%d) %lld",
                                        __func__, j, i,
@@ -367,7 +367,7 @@ xfs_bmap_check_leaf_extents(
        level = be16_to_cpu(block->bb_level);
        ASSERT(level > 0);
        xfs_check_block(block, mp, 1, ifp->if_broot_bytes);
-       pp = XFS_BMAP_BROOT_PTR_ADDR(mp, block, 1, ifp->if_broot_bytes);
+       pp = xfs_bmap_broot_ptr_addr(mp, block, 1, ifp->if_broot_bytes);
        bno = be64_to_cpu(*pp);
 
        ASSERT(bno != NULLFSBLOCK);
@@ -400,7 +400,7 @@ xfs_bmap_check_leaf_extents(
                 */
 
                xfs_check_block(block, mp, 0, 0);
-               pp = XFS_BMBT_PTR_ADDR(mp, block, 1, mp->m_bmap_dmxr[1]);
+               pp = xfs_bmbt_ptr_addr(mp, block, 1, mp->m_bmap_dmxr[1]);
                bno = be64_to_cpu(*pp);
                if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbno(mp, bno))) {
                        xfs_btree_mark_sick(cur);
@@ -440,14 +440,14 @@ xfs_bmap_check_leaf_extents(
                 * conform with the first entry in this one.
                 */
 
-               ep = XFS_BMBT_REC_ADDR(mp, block, 1);
+               ep = xfs_bmbt_rec_addr(mp, block, 1);
                if (i) {
                        ASSERT(xfs_bmbt_disk_get_startoff(&last) +
                               xfs_bmbt_disk_get_blockcount(&last) <=
                               xfs_bmbt_disk_get_startoff(ep));
                }
                for (j = 1; j < num_recs; j++) {
-                       nextp = XFS_BMBT_REC_ADDR(mp, block, j + 1);
+                       nextp = xfs_bmbt_rec_addr(mp, block, j + 1);
                        ASSERT(xfs_bmbt_disk_get_startoff(ep) +
                               xfs_bmbt_disk_get_blockcount(ep) <=
                               xfs_bmbt_disk_get_startoff(nextp));
@@ -580,7 +580,7 @@ xfs_bmap_btree_to_extents(
        ASSERT(be16_to_cpu(rblock->bb_numrecs) == 1);
        ASSERT(xfs_bmbt_maxrecs(mp, ifp->if_broot_bytes, 0) == 1);
 
-       pp = XFS_BMAP_BROOT_PTR_ADDR(mp, rblock, 1, ifp->if_broot_bytes);
+       pp = xfs_bmap_broot_ptr_addr(mp, rblock, 1, ifp->if_broot_bytes);
        cbno = be64_to_cpu(*pp);
 #ifdef DEBUG
        if (XFS_IS_CORRUPT(cur->bc_mp, !xfs_verify_fsbno(mp, cbno))) {
@@ -708,7 +708,7 @@ xfs_bmap_extents_to_btree(
        for_each_xfs_iext(ifp, &icur, &rec) {
                if (isnullstartblock(rec.br_startblock))
                        continue;
-               arp = XFS_BMBT_REC_ADDR(mp, ablock, 1 + cnt);
+               arp = xfs_bmbt_rec_addr(mp, ablock, 1 + cnt);
                xfs_bmbt_disk_set_all(arp, &rec);
                cnt++;
        }
@@ -718,10 +718,10 @@ xfs_bmap_extents_to_btree(
        /*
         * Fill in the root key and pointer.
         */
-       kp = XFS_BMBT_KEY_ADDR(mp, block, 1);
-       arp = XFS_BMBT_REC_ADDR(mp, ablock, 1);
+       kp = xfs_bmbt_key_addr(mp, block, 1);
+       arp = xfs_bmbt_rec_addr(mp, ablock, 1);
        kp->br_startoff = cpu_to_be64(xfs_bmbt_disk_get_startoff(arp));
-       pp = XFS_BMBT_PTR_ADDR(mp, block, 1, xfs_bmbt_get_maxrecs(cur,
+       pp = xfs_bmbt_ptr_addr(mp, block, 1, xfs_bmbt_get_maxrecs(cur,
                                                be16_to_cpu(block->bb_level)));
        *pp = cpu_to_be64(args.fsbno);
 
@@ -890,7 +890,7 @@ xfs_bmap_add_attrfork_btree(
 
        mp = ip->i_mount;
 
-       if (XFS_BMAP_BMDR_SPACE(block) <= xfs_inode_data_fork_size(ip))
+       if (xfs_bmap_bmdr_space(block) <= xfs_inode_data_fork_size(ip))
                *flags |= XFS_ILOG_DBROOT;
        else {
                cur = xfs_bmbt_init_cursor(mp, tp, ip, XFS_DATA_FORK);
@@ -1154,7 +1154,7 @@ xfs_iread_bmbt_block(
        }
 
        /* Copy records into the incore cache. */
-       frp = XFS_BMBT_REC_ADDR(mp, block, 1);
+       frp = xfs_bmbt_rec_addr(mp, block, 1);
        for (j = 0; j < num_recs; j++, frp++, ir->loaded++) {
                struct xfs_bmbt_irec    new;
                xfs_failaddr_t          fa;
index a14ca35953d735276b54e3203baff0c35d2d50ff..cac644c8ce35a5d63379ce2e923a59a84b3a93f5 100644 (file)
@@ -64,10 +64,10 @@ xfs_bmdr_to_bmbt(
        ASSERT(be16_to_cpu(rblock->bb_level) > 0);
        rblock->bb_numrecs = dblock->bb_numrecs;
        dmxr = xfs_bmdr_maxrecs(dblocklen, 0);
-       fkp = XFS_BMDR_KEY_ADDR(dblock, 1);
-       tkp = XFS_BMBT_KEY_ADDR(mp, rblock, 1);
-       fpp = XFS_BMDR_PTR_ADDR(dblock, 1, dmxr);
-       tpp = XFS_BMAP_BROOT_PTR_ADDR(mp, rblock, 1, rblocklen);
+       fkp = xfs_bmdr_key_addr(dblock, 1);
+       tkp = xfs_bmbt_key_addr(mp, rblock, 1);
+       fpp = xfs_bmdr_ptr_addr(dblock, 1, dmxr);
+       tpp = xfs_bmap_broot_ptr_addr(mp, rblock, 1, rblocklen);
        dmxr = be16_to_cpu(dblock->bb_numrecs);
        memcpy(tkp, fkp, sizeof(*fkp) * dmxr);
        memcpy(tpp, fpp, sizeof(*fpp) * dmxr);
@@ -167,10 +167,10 @@ xfs_bmbt_to_bmdr(
        dblock->bb_level = rblock->bb_level;
        dblock->bb_numrecs = rblock->bb_numrecs;
        dmxr = xfs_bmdr_maxrecs(dblocklen, 0);
-       fkp = XFS_BMBT_KEY_ADDR(mp, rblock, 1);
-       tkp = XFS_BMDR_KEY_ADDR(dblock, 1);
-       fpp = XFS_BMAP_BROOT_PTR_ADDR(mp, rblock, 1, rblocklen);
-       tpp = XFS_BMDR_PTR_ADDR(dblock, 1, dmxr);
+       fkp = xfs_bmbt_key_addr(mp, rblock, 1);
+       tkp = xfs_bmdr_key_addr(dblock, 1);
+       fpp = xfs_bmap_broot_ptr_addr(mp, rblock, 1, rblocklen);
+       tpp = xfs_bmdr_ptr_addr(dblock, 1, dmxr);
        dmxr = be16_to_cpu(dblock->bb_numrecs);
        memcpy(tkp, fkp, sizeof(*fkp) * dmxr);
        memcpy(tpp, fpp, sizeof(*fpp) * dmxr);
@@ -650,7 +650,7 @@ xfs_bmbt_maxrecs(
        int                     blocklen,
        int                     leaf)
 {
-       blocklen -= XFS_BMBT_BLOCK_LEN(mp);
+       blocklen -= xfs_bmbt_block_len(mp);
        return xfs_bmbt_block_maxrecs(blocklen, leaf);
 }
 
index de1b73f1225ca7df1d821f78eab3b29f57167453..d006798d591bc21814b35dc080b5b8fe9c7479f4 100644 (file)
@@ -13,70 +13,6 @@ struct xfs_inode;
 struct xfs_trans;
 struct xbtree_ifakeroot;
 
-/*
- * Btree block header size depends on a superblock flag.
- */
-#define XFS_BMBT_BLOCK_LEN(mp) \
-       (xfs_has_crc(((mp))) ? \
-               XFS_BTREE_LBLOCK_CRC_LEN : XFS_BTREE_LBLOCK_LEN)
-
-#define XFS_BMBT_REC_ADDR(mp, block, index) \
-       ((xfs_bmbt_rec_t *) \
-               ((char *)(block) + \
-                XFS_BMBT_BLOCK_LEN(mp) + \
-                ((index) - 1) * sizeof(xfs_bmbt_rec_t)))
-
-#define XFS_BMBT_KEY_ADDR(mp, block, index) \
-       ((xfs_bmbt_key_t *) \
-               ((char *)(block) + \
-                XFS_BMBT_BLOCK_LEN(mp) + \
-                ((index) - 1) * sizeof(xfs_bmbt_key_t)))
-
-#define XFS_BMBT_PTR_ADDR(mp, block, index, maxrecs) \
-       ((xfs_bmbt_ptr_t *) \
-               ((char *)(block) + \
-                XFS_BMBT_BLOCK_LEN(mp) + \
-                (maxrecs) * sizeof(xfs_bmbt_key_t) + \
-                ((index) - 1) * sizeof(xfs_bmbt_ptr_t)))
-
-#define XFS_BMDR_REC_ADDR(block, index) \
-       ((xfs_bmdr_rec_t *) \
-               ((char *)(block) + \
-                sizeof(struct xfs_bmdr_block) + \
-                ((index) - 1) * sizeof(xfs_bmdr_rec_t)))
-
-#define XFS_BMDR_KEY_ADDR(block, index) \
-       ((xfs_bmdr_key_t *) \
-               ((char *)(block) + \
-                sizeof(struct xfs_bmdr_block) + \
-                ((index) - 1) * sizeof(xfs_bmdr_key_t)))
-
-#define XFS_BMDR_PTR_ADDR(block, index, maxrecs) \
-       ((xfs_bmdr_ptr_t *) \
-               ((char *)(block) + \
-                sizeof(struct xfs_bmdr_block) + \
-                (maxrecs) * sizeof(xfs_bmdr_key_t) + \
-                ((index) - 1) * sizeof(xfs_bmdr_ptr_t)))
-
-/*
- * These are to be used when we know the size of the block and
- * we don't have a cursor.
- */
-#define XFS_BMAP_BROOT_PTR_ADDR(mp, bb, i, sz) \
-       XFS_BMBT_PTR_ADDR(mp, bb, i, xfs_bmbt_maxrecs(mp, sz, 0))
-
-#define XFS_BMAP_BROOT_SPACE_CALC(mp, nrecs) \
-       (int)(XFS_BMBT_BLOCK_LEN(mp) + \
-              ((nrecs) * (sizeof(xfs_bmbt_key_t) + sizeof(xfs_bmbt_ptr_t))))
-
-#define XFS_BMAP_BROOT_SPACE(mp, bb) \
-       (XFS_BMAP_BROOT_SPACE_CALC(mp, be16_to_cpu((bb)->bb_numrecs)))
-#define XFS_BMDR_SPACE_CALC(nrecs) \
-       (int)(sizeof(xfs_bmdr_block_t) + \
-              ((nrecs) * (sizeof(xfs_bmbt_key_t) + sizeof(xfs_bmbt_ptr_t))))
-#define XFS_BMAP_BMDR_SPACE(bb) \
-       (XFS_BMDR_SPACE_CALC(be16_to_cpu((bb)->bb_numrecs)))
-
 /*
  * Maximum number of bmap btree levels.
  */
@@ -121,4 +57,144 @@ void xfs_bmbt_destroy_cur_cache(void);
 void xfs_bmbt_init_block(struct xfs_inode *ip, struct xfs_btree_block *buf,
                struct xfs_buf *bp, __u16 level, __u16 numrecs);
 
+/*
+ * Btree block header size depends on a superblock flag.
+ */
+static inline size_t
+xfs_bmbt_block_len(struct xfs_mount *mp)
+{
+       return xfs_has_crc(mp) ?
+                       XFS_BTREE_LBLOCK_CRC_LEN : XFS_BTREE_LBLOCK_LEN;
+}
+
+/* Addresses of key, pointers, and records within an incore bmbt block. */
+
+static inline struct xfs_bmbt_rec *
+xfs_bmbt_rec_addr(
+       struct xfs_mount        *mp,
+       struct xfs_btree_block  *block,
+       unsigned int            index)
+{
+       return (struct xfs_bmbt_rec *)
+               ((char *)block + xfs_bmbt_block_len(mp) +
+                (index - 1) * sizeof(struct xfs_bmbt_rec));
+}
+
+static inline struct xfs_bmbt_key *
+xfs_bmbt_key_addr(
+       struct xfs_mount        *mp,
+       struct xfs_btree_block  *block,
+       unsigned int            index)
+{
+       return (struct xfs_bmbt_key *)
+               ((char *)block + xfs_bmbt_block_len(mp) +
+                (index - 1) * sizeof(struct xfs_bmbt_key *));
+}
+
+static inline xfs_bmbt_ptr_t *
+xfs_bmbt_ptr_addr(
+       struct xfs_mount        *mp,
+       struct xfs_btree_block  *block,
+       unsigned int            index,
+       unsigned int            maxrecs)
+{
+       return (xfs_bmbt_ptr_t *)
+               ((char *)block + xfs_bmbt_block_len(mp) +
+                maxrecs * sizeof(struct xfs_bmbt_key) +
+                (index - 1) * sizeof(xfs_bmbt_ptr_t));
+}
+
+/* Addresses of key, pointers, and records within an ondisk bmbt block. */
+
+static inline struct xfs_bmbt_rec *
+xfs_bmdr_rec_addr(
+       struct xfs_bmdr_block   *block,
+       unsigned int            index)
+{
+       return (struct xfs_bmbt_rec *)
+               ((char *)(block + 1) +
+                (index - 1) * sizeof(struct xfs_bmbt_rec));
+}
+
+static inline struct xfs_bmbt_key *
+xfs_bmdr_key_addr(
+       struct xfs_bmdr_block   *block,
+       unsigned int            index)
+{
+       return (struct xfs_bmbt_key *)
+               ((char *)(block + 1) +
+                (index - 1) * sizeof(struct xfs_bmbt_key));
+}
+
+static inline xfs_bmbt_ptr_t *
+xfs_bmdr_ptr_addr(
+       struct xfs_bmdr_block   *block,
+       unsigned int            index,
+       unsigned int            maxrecs)
+{
+       return (xfs_bmbt_ptr_t *)
+               ((char *)(block + 1) +
+                maxrecs * sizeof(struct xfs_bmbt_key) +
+                (index - 1) * sizeof(xfs_bmbt_ptr_t));
+}
+
+/*
+ * Address of pointers within the incore btree root.
+ *
+ * These are to be used when we know the size of the block and
+ * we don't have a cursor.
+ */
+static inline xfs_bmbt_ptr_t *
+xfs_bmap_broot_ptr_addr(
+       struct xfs_mount        *mp,
+       struct xfs_btree_block  *bb,
+       unsigned int            i,
+       unsigned int            sz)
+{
+       return xfs_bmbt_ptr_addr(mp, bb, i, xfs_bmbt_maxrecs(mp, sz, 0));
+}
+
+/*
+ * Compute the space required for the incore btree root containing the given
+ * number of records.
+ */
+static inline size_t
+xfs_bmap_broot_space_calc(
+       struct xfs_mount        *mp,
+       unsigned int            nrecs)
+{
+       return xfs_bmbt_block_len(mp) +
+              (nrecs * (sizeof(struct xfs_bmbt_key) + sizeof(xfs_bmbt_ptr_t)));
+}
+
+/*
+ * Compute the space required for the incore btree root given the ondisk
+ * btree root block.
+ */
+static inline size_t
+xfs_bmap_broot_space(
+       struct xfs_mount        *mp,
+       struct xfs_bmdr_block   *bb)
+{
+       return xfs_bmap_broot_space_calc(mp, be16_to_cpu(bb->bb_numrecs));
+}
+
+/* Compute the space required for the ondisk root block. */
+static inline size_t
+xfs_bmdr_space_calc(unsigned int nrecs)
+{
+       return sizeof(struct xfs_bmdr_block) +
+              (nrecs * (sizeof(struct xfs_bmbt_key) + sizeof(xfs_bmbt_ptr_t)));
+}
+
+/*
+ * Compute the space required for the ondisk root block given an incore root
+ * block.
+ */
+static inline size_t
+xfs_bmap_bmdr_space(struct xfs_btree_block *bb)
+{
+       return xfs_bmdr_space_calc(be16_to_cpu(bb->bb_numrecs));
+}
+
 #endif /* __XFS_BMAP_BTREE_H__ */
index 8f06e5bc72b3ac702f016c2ddd35a34676d3798b..fd79da64e43a8d91abd24b28a3790426edbcde6d 100644 (file)
@@ -183,7 +183,7 @@ xfs_iformat_btree(
 
        ifp = xfs_ifork_ptr(ip, whichfork);
        dfp = (xfs_bmdr_block_t *)XFS_DFORK_PTR(dip, whichfork);
-       size = XFS_BMAP_BROOT_SPACE(mp, dfp);
+       size = xfs_bmap_broot_space(mp, dfp);
        nrecs = be16_to_cpu(dfp->bb_numrecs);
        level = be16_to_cpu(dfp->bb_level);
 
@@ -196,7 +196,7 @@ xfs_iformat_btree(
         */
        if (unlikely(ifp->if_nextents <= XFS_IFORK_MAXEXT(ip, whichfork) ||
                     nrecs == 0 ||
-                    XFS_BMDR_SPACE_CALC(nrecs) >
+                    xfs_bmdr_space_calc(nrecs) >
                                        XFS_DFORK_SIZE(dip, mp, whichfork) ||
                     ifp->if_nextents > ip->i_nblocks) ||
                     level == 0 || level > XFS_BM_MAXLEVELS(mp, whichfork)) {
@@ -407,7 +407,7 @@ xfs_iroot_realloc(
                 * allocate it now and get out.
                 */
                if (ifp->if_broot_bytes == 0) {
-                       new_size = XFS_BMAP_BROOT_SPACE_CALC(mp, rec_diff);
+                       new_size = xfs_bmap_broot_space_calc(mp, rec_diff);
                        ifp->if_broot = kmalloc(new_size,
                                                GFP_KERNEL | __GFP_NOFAIL);
                        ifp->if_broot_bytes = (int)new_size;
@@ -422,15 +422,15 @@ xfs_iroot_realloc(
                 */
                cur_max = xfs_bmbt_maxrecs(mp, ifp->if_broot_bytes, 0);
                new_max = cur_max + rec_diff;
-               new_size = XFS_BMAP_BROOT_SPACE_CALC(mp, new_max);
+               new_size = xfs_bmap_broot_space_calc(mp, new_max);
                ifp->if_broot = krealloc(ifp->if_broot, new_size,
                                         GFP_KERNEL | __GFP_NOFAIL);
-               op = (char *)XFS_BMAP_BROOT_PTR_ADDR(mp, ifp->if_broot, 1,
+               op = (char *)xfs_bmap_broot_ptr_addr(mp, ifp->if_broot, 1,
                                                     ifp->if_broot_bytes);
-               np = (char *)XFS_BMAP_BROOT_PTR_ADDR(mp, ifp->if_broot, 1,
+               np = (char *)xfs_bmap_broot_ptr_addr(mp, ifp->if_broot, 1,
                                                     (int)new_size);
                ifp->if_broot_bytes = (int)new_size;
-               ASSERT(XFS_BMAP_BMDR_SPACE(ifp->if_broot) <=
+               ASSERT(xfs_bmap_bmdr_space(ifp->if_broot) <=
                        xfs_inode_fork_size(ip, whichfork));
                memmove(np, op, cur_max * (uint)sizeof(xfs_fsblock_t));
                return;
@@ -446,7 +446,7 @@ xfs_iroot_realloc(
        new_max = cur_max + rec_diff;
        ASSERT(new_max >= 0);
        if (new_max > 0)
-               new_size = XFS_BMAP_BROOT_SPACE_CALC(mp, new_max);
+               new_size = xfs_bmap_broot_space_calc(mp, new_max);
        else
                new_size = 0;
        if (new_size > 0) {
@@ -455,7 +455,7 @@ xfs_iroot_realloc(
                 * First copy over the btree block header.
                 */
                memcpy(new_broot, ifp->if_broot,
-                       XFS_BMBT_BLOCK_LEN(ip->i_mount));
+                       xfs_bmbt_block_len(ip->i_mount));
        } else {
                new_broot = NULL;
        }
@@ -467,16 +467,16 @@ xfs_iroot_realloc(
                /*
                 * First copy the keys.
                 */
-               op = (char *)XFS_BMBT_KEY_ADDR(mp, ifp->if_broot, 1);
-               np = (char *)XFS_BMBT_KEY_ADDR(mp, new_broot, 1);
+               op = (char *)xfs_bmbt_key_addr(mp, ifp->if_broot, 1);
+               np = (char *)xfs_bmbt_key_addr(mp, new_broot, 1);
                memcpy(np, op, new_max * (uint)sizeof(xfs_bmbt_key_t));
 
                /*
                 * Then copy the pointers.
                 */
-               op = (char *)XFS_BMAP_BROOT_PTR_ADDR(mp, ifp->if_broot, 1,
+               op = (char *)xfs_bmap_broot_ptr_addr(mp, ifp->if_broot, 1,
                                                     ifp->if_broot_bytes);
-               np = (char *)XFS_BMAP_BROOT_PTR_ADDR(mp, new_broot, 1,
+               np = (char *)xfs_bmap_broot_ptr_addr(mp, new_broot, 1,
                                                     (int)new_size);
                memcpy(np, op, new_max * (uint)sizeof(xfs_fsblock_t));
        }
@@ -484,7 +484,7 @@ xfs_iroot_realloc(
        ifp->if_broot = new_broot;
        ifp->if_broot_bytes = (int)new_size;
        if (ifp->if_broot)
-               ASSERT(XFS_BMAP_BMDR_SPACE(ifp->if_broot) <=
+               ASSERT(xfs_bmap_bmdr_space(ifp->if_broot) <=
                        xfs_inode_fork_size(ip, whichfork));
        return;
 }
@@ -653,7 +653,7 @@ xfs_iflush_fork(
                if ((iip->ili_fields & brootflag[whichfork]) &&
                    (ifp->if_broot_bytes > 0)) {
                        ASSERT(ifp->if_broot != NULL);
-                       ASSERT(XFS_BMAP_BMDR_SPACE(ifp->if_broot) <=
+                       ASSERT(xfs_bmap_bmdr_space(ifp->if_broot) <=
                                xfs_inode_fork_size(ip, whichfork));
                        xfs_bmbt_to_bmdr(mp, ifp->if_broot, ifp->if_broot_bytes,
                                (xfs_bmdr_block_t *)cp,
index 156f9578d281a04ae6544f0fbc29386152963c60..3da18fb4027420770e0fa63952c6c4008fc774e8 100644 (file)
@@ -127,7 +127,7 @@ xfs_calc_inode_res(
                (4 * sizeof(struct xlog_op_header) +
                 sizeof(struct xfs_inode_log_format) +
                 mp->m_sb.sb_inodesize +
-                2 * XFS_BMBT_BLOCK_LEN(mp));
+                2 * xfs_bmbt_block_len(mp));
 }
 
 /*
index 317061aa564f563f7baab0f72d041c2bcea12083..b341caf627d5fda768abc063f5b4f1668df3fb5c 100644 (file)
@@ -284,7 +284,7 @@ xrep_bmap_iroot_size(
 {
        ASSERT(level > 0);
 
-       return XFS_BMAP_BROOT_SPACE_CALC(cur->bc_mp, nr_this_level);
+       return xfs_bmap_broot_space_calc(cur->bc_mp, nr_this_level);
 }
 
 /* Update the inode counters. */
index aae3cb7a40b9810beaf51fc0485afbbedd4f66fe..ac81c487a20b8a0b36aec4285ee970b7fd966074 100644 (file)
@@ -809,19 +809,19 @@ _("bad numrecs 0 in inode %" PRIu64 " bmap btree root block\n"),
        /*
         * use bmdr/dfork_dsize since the root block is in the data fork
         */
-       if (XFS_BMDR_SPACE_CALC(numrecs) > XFS_DFORK_SIZE(dip, mp, whichfork)) {
+       if (xfs_bmdr_space_calc(numrecs) > XFS_DFORK_SIZE(dip, mp, whichfork)) {
                do_warn(
-       _("indicated size of %s btree root (%d bytes) greater than space in "
+       _("indicated size of %s btree root (%zu bytes) greater than space in "
          "inode %" PRIu64 " %s fork\n"),
-                       forkname, XFS_BMDR_SPACE_CALC(numrecs), lino, forkname);
+                       forkname, xfs_bmdr_space_calc(numrecs), lino, forkname);
                return(1);
        }
 
        init_bm_cursor(&cursor, level + 1);
 
-       pp = XFS_BMDR_PTR_ADDR(dib, 1,
+       pp = xfs_bmdr_ptr_addr(dib, 1,
                libxfs_bmdr_maxrecs(XFS_DFORK_SIZE(dip, mp, whichfork), 0));
-       pkey = XFS_BMDR_KEY_ADDR(dib, 1);
+       pkey = xfs_bmdr_key_addr(dib, 1);
        last_key = NULLFILEOFF;
 
        for (i = 0; i < numrecs; i++)  {
index 22efd54bf9ebf340a9c448815b20293dde96144e..998797e3696bace89d8f7590124be517a0899a8d 100644 (file)
@@ -328,13 +328,13 @@ pf_scanfunc_bmap(
                if (numrecs > mp->m_bmap_dmxr[0] || !isadir)
                        return 0;
                return pf_read_bmbt_reclist(args,
-                       XFS_BMBT_REC_ADDR(mp, block, 1), numrecs);
+                       xfs_bmbt_rec_addr(mp, block, 1), numrecs);
        }
 
        if (numrecs > mp->m_bmap_dmxr[1])
                return 0;
 
-       pp = XFS_BMBT_PTR_ADDR(mp, block, 1, mp->m_bmap_dmxr[1]);
+       pp = xfs_bmbt_ptr_addr(mp, block, 1, mp->m_bmap_dmxr[1]);
 
        for (i = 0; i < numrecs; i++) {
                dbno = get_unaligned_be64(&pp[i]);
@@ -372,11 +372,11 @@ pf_read_btinode(
        /*
         * use bmdr/dfork_dsize since the root block is in the data fork
         */
-       if (XFS_BMDR_SPACE_CALC(numrecs) > XFS_DFORK_DSIZE(dino, mp))
+       if (xfs_bmdr_space_calc(numrecs) > XFS_DFORK_DSIZE(dino, mp))
                return;
 
        dsize = XFS_DFORK_DSIZE(dino, mp);
-       pp = XFS_BMDR_PTR_ADDR(dib, 1, libxfs_bmdr_maxrecs(dsize, 0));
+       pp = xfs_bmdr_ptr_addr(dib, 1, libxfs_bmdr_maxrecs(dsize, 0));
 
        for (i = 0; i < numrecs; i++) {
                dbno = get_unaligned_be64(&pp[i]);
index 8352b3ccff7d7e292ba5e5803de9146f09d275fb..b115dd4948b96941aca3499fdebecd8f639ddba0 100644 (file)
@@ -416,7 +416,7 @@ _("inode %" PRIu64 " bad # of bmap records (%" PRIu64 ", min - %u, max - %u)\n")
                                        mp->m_bmap_dmxr[0]);
                        return(1);
                }
-               rp = XFS_BMBT_REC_ADDR(mp, block, 1);
+               rp = xfs_bmbt_rec_addr(mp, block, 1);
                *nex += numrecs;
                /*
                 * XXX - if we were going to fix up the btree record,
@@ -466,8 +466,8 @@ _("inode %" PRIu64 " bad # of bmap records (%" PRIu64 ", min - %u, max - %u)\n")
                        ino, numrecs, mp->m_bmap_dmnr[1], mp->m_bmap_dmxr[1]);
                return(1);
        }
-       pp = XFS_BMBT_PTR_ADDR(mp, block, 1, mp->m_bmap_dmxr[1]);
-       pkey = XFS_BMBT_KEY_ADDR(mp, block, 1);
+       pp = xfs_bmbt_ptr_addr(mp, block, 1, mp->m_bmap_dmxr[1]);
+       pkey = xfs_bmbt_key_addr(mp, block, 1);
 
        last_key = NULLFILEOFF;