ASoC: codecs: wsa883x: Handle reading version failure

If reading version and variant from registers fails (which is unlikely
but possible, because it is a read over bus), the driver will proceed
and perform device configuration based on uninitialized stack variables.
Handle it a bit better - bail out without doing any init and failing the
update status Soundwire callback.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20240710-asoc-wsa88xx-version-v1-2-f1c54966ccde@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c
index d0ab4e2290b6a9f049a95534cbe7673b9c1ae594..89e256bfb553347a68b5b5015b60b179d2874d01 100644 (file)
--- a/sound/soc/codecs/wsa883x.c
+++ b/sound/soc/codecs/wsa883x.c
@@ -997,15 +997,19 @@ static const struct reg_sequence reg_init[] = {
        {WSA883X_GMAMP_SUP1, 0xE2},
 };
 
-static void wsa883x_init(struct wsa883x_priv *wsa883x)
+static int wsa883x_init(struct wsa883x_priv *wsa883x)
 {
        struct regmap *regmap = wsa883x->regmap;
-       int variant, version;
+       int variant, version, ret;
 
-       regmap_read(regmap, WSA883X_OTP_REG_0, &variant);
+       ret = regmap_read(regmap, WSA883X_OTP_REG_0, &variant);
+       if (ret)
+               return ret;
        wsa883x->variant = variant & WSA883X_ID_MASK;
 
-       regmap_read(regmap, WSA883X_CHIP_ID0, &version);
+       ret = regmap_read(regmap, WSA883X_CHIP_ID0, &version);
+       if (ret)
+               return ret;
        wsa883x->version = version;
 
        switch (wsa883x->variant) {
@@ -1040,6 +1044,8 @@ static void wsa883x_init(struct wsa883x_priv *wsa883x)
                                   WSA883X_DRE_OFFSET_MASK,
                                   wsa883x->comp_offset);
        }
+
+       return 0;
 }
 
 static int wsa883x_update_status(struct sdw_slave *slave,
@@ -1048,7 +1054,7 @@ static int wsa883x_update_status(struct sdw_slave *slave,
        struct wsa883x_priv *wsa883x = dev_get_drvdata(&slave->dev);
 
        if (status == SDW_SLAVE_ATTACHED && slave->dev_num > 0)
-               wsa883x_init(wsa883x);
+               return wsa883x_init(wsa883x);
 
        return 0;
 }