]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
drivers: clk: agilex: Use FIELD_GET during EMAC clock selection
authorNaresh Kumar Ravulapalli <nareshkumar.ravulapalli@altera.com>
Thu, 11 Sep 2025 05:21:12 +0000 (22:21 -0700)
committerTien Fong Chee <tien.fong.chee@intel.com>
Tue, 30 Sep 2025 06:29:56 +0000 (14:29 +0800)
FIELD_GET() macro is used during EMAC clock source selection
for better code readability and maintainability.

Signed-off-by: Naresh Kumar Ravulapalli <nareshkumar.ravulapalli@altera.com>
Reviewed-by: Tien Fong Chee <tien.fong.chee@altera.com>
drivers/clk/altera/clk-agilex.c

index 19c4e8220db8c5caf7ea1c340d5a4b225ef47f94..fdbf834bb2f6ae85025a2d11f25f8b1de025871d 100644 (file)
@@ -14,6 +14,7 @@
 #include <dm/lists.h>
 #include <dm/util.h>
 #include <dt-bindings/clock/agilex-clock.h>
+#include <linux/bitfield.h>
 #include <linux/bitops.h>
 
 #include <asm/arch/clock_manager.h>
@@ -546,14 +547,11 @@ static u32 clk_get_emac_clk_hz(struct socfpga_clk_plat *plat, u32 emac_id)
        /* Get EMAC clock source */
        ctl = CM_REG_READL(plat, CLKMGR_PERPLL_EMACCTL);
        if (emac_id == AGILEX_EMAC0_CLK)
-               ctl = (ctl & CLKMGR_PERPLLGRP_EMACCTL_EMAC0SELB_MASK) >>
-                       CLKMGR_PERPLLGRP_EMACCTL_EMAC0SELB_OFFSET;
+               ctl = FIELD_GET(CLKMGR_PERPLLGRP_EMACCTL_EMAC0SELB_MASK, ctl);
        else if (emac_id == AGILEX_EMAC1_CLK)
-               ctl = (ctl & CLKMGR_PERPLLGRP_EMACCTL_EMAC1SELB_MASK) >>
-                       CLKMGR_PERPLLGRP_EMACCTL_EMAC1SELB_OFFSET;
+               ctl = FIELD_GET(CLKMGR_PERPLLGRP_EMACCTL_EMAC1SELB_MASK, ctl);
        else if (emac_id == AGILEX_EMAC2_CLK)
-               ctl = (ctl & CLKMGR_PERPLLGRP_EMACCTL_EMAC2SELB_MASK) >>
-                       CLKMGR_PERPLLGRP_EMACCTL_EMAC2SELB_OFFSET;
+               ctl = FIELD_GET(CLKMGR_PERPLLGRP_EMACCTL_EMAC2SELB_MASK, ctl);
        else
                return 0;