python/samdb: no need to set member_base_dn multiple times

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Jule Anger <janger@samba.org>

diff --git a/python/samba/samdb.py b/python/samba/samdb.py
index 596411be9e01c31c651fc0b63a18a0c9e41e258e..7cfb3459e3c6faaf2d13e9ad74fd1cc6b811f688 100644 (file)
--- a/python/samba/samdb.py
+++ b/python/samba/samdb.py
@@ -382,6 +382,9 @@ lockoutTime: 0
         if member_types is None:
             member_types = ['user', 'group', 'computer']
 
+        if member_base_dn is None:
+            member_base_dn = self.domain_dn()
+
         groupfilter = "(&(sAMAccountName=%s)(objectCategory=%s,%s))" % (
             ldb.binary_encode(groupname), "CN=Group,CN=Schema,CN=Configuration", self.domain_dn())
 
@@ -405,9 +408,6 @@ changetype: modify
 
             for member in members:
                 targetmember_dn = None
-                if member_base_dn is None:
-                    member_base_dn = self.domain_dn()
-
                 membersid = None
                 try:
                     membersid = security.dom_sid(member)