]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ctdb-tests: Use ctdb_test_skip() when shellcheck is not installed
authorMartin Schwenke <martin@meltin.net>
Tue, 3 Mar 2020 06:48:40 +0000 (17:48 +1100)
committerAmitay Isaacs <amitay@samba.org>
Tue, 10 Mar 2020 07:37:34 +0000 (07:37 +0000)
When the tests are run interactively this will make it more noticeable
that shellcheck is not installed because the test summary will
indicate missing tests.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/tests/UNIT/shellcheck/scripts/local.sh

index 84019144009595b72b645a0e4edd8190122b1e02..6bc93fd9146f16709863f716af990f17d13c997f 100644 (file)
@@ -31,7 +31,7 @@ shellcheck_test ()
                _excludes="SC1090,SC1091,SC2162,SC2164"
                unit_test shellcheck --exclude="$_excludes" "$@"
        else
-               echo "WARNING: shellcheck not installed, skipping test"
+               ctdb_test_skip "shellcheck not installed"
                unit_test true
        fi
 }