]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: add debug check in skb_reset_network_header()
authorEric Dumazet <edumazet@google.com>
Tue, 5 Nov 2024 17:44:02 +0000 (17:44 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 7 Nov 2024 01:29:15 +0000 (17:29 -0800)
Make sure (skb->data - skb->head) can fit in skb->network_header

This needs CONFIG_DEBUG_NET=y.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Link: https://patch.msgid.link/20241105174403.850330-7-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/skbuff.h

index f76524844e7edc5fe4e0afc27ce71eed7fbd40f9..f1e49a32880df8f3716c585d13c1085a2183978a 100644 (file)
@@ -3027,7 +3027,10 @@ static inline unsigned char *skb_network_header(const struct sk_buff *skb)
 
 static inline void skb_reset_network_header(struct sk_buff *skb)
 {
-       skb->network_header = skb->data - skb->head;
+       long offset = skb->data - skb->head;
+
+       DEBUG_NET_WARN_ON_ONCE(offset != (typeof(skb->network_header))offset);
+       skb->network_header = offset;
 }
 
 static inline void skb_set_network_header(struct sk_buff *skb, const int offset)