ctdbd_conn: Fix CID 1301580 Explicit null dereferenced

Coverity does not really tell me which code path it sees where we could leave
hdr==NULL, but this check does not hurt.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri May 29 19:49:30 CEST 2015 on sn-devel-104

diff --git a/source3/lib/ctdbd_conn.c b/source3/lib/ctdbd_conn.c
index 66c87c55c56bbb5fe3cd66f2f3addc32635fa80a..3aa5ced5fb013ab9a6e967faf84cbab962a18827 100644 (file)
--- a/source3/lib/ctdbd_conn.c
+++ b/source3/lib/ctdbd_conn.c
@@ -1295,7 +1295,7 @@ NTSTATUS ctdbd_parse(struct ctdbd_connection *conn, uint32_t db_id,
                goto fail;
        }
 
-       if (hdr->operation != CTDB_REPLY_CALL) {
+       if ((hdr == NULL) || (hdr->operation != CTDB_REPLY_CALL)) {
                DEBUG(0, ("received invalid reply\n"));
                status = NT_STATUS_INTERNAL_ERROR;
                goto fail;