re PR tree-optimization/28162 (ICE in set_value_range, at tree-vrp.c:157)

2006-07-05  Richard Guenther  <rguenther@suse.de>

	PR tree-optimization/28162
	* fold-const.c (fold_binary): For (-A) * (-B) -> A * B
	make sure to convert the operands to the correct type.

	* gcc.dg/pr28162.c: New testcase.

From-SVN: r115202

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index ba7b529d68c9d26239294cd76ad9ac2039c2d40e..798fe03a3c1590d1d7690878f40cd60f843fdd15 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2006-07-05  Richard Guenther  <rguenther@suse.de>
+
+       PR tree-optimization/28162
+       * fold-const.c (fold_binary): For (-A) * (-B) -> A * B
+       make sure to convert the operands to the correct type.
+
 2006-07-04  Paolo Bonzini  <bonzini@gnu.org>
 
        PR tree-optimization/28218

diff --git a/gcc/fold-const.c b/gcc/fold-const.c
index 5c592c3d87d4ae3e8bcc58f672e613bcd5fee0ad..008310c21a405f4dd826235aa058b5834869686b 100644 (file)
--- a/gcc/fold-const.c
+++ b/gcc/fold-const.c
@@ -8852,12 +8852,12 @@ fold_binary (enum tree_code code, tree type, tree op0, tree op1)
       /* (-A) * (-B) -> A * B  */
       if (TREE_CODE (arg0) == NEGATE_EXPR && negate_expr_p (arg1))
        return fold_build2 (MULT_EXPR, type,
-                           TREE_OPERAND (arg0, 0),
-                           negate_expr (arg1));
+                           fold_convert (type, TREE_OPERAND (arg0, 0)),
+                           fold_convert (type, negate_expr (arg1)));
       if (TREE_CODE (arg1) == NEGATE_EXPR && negate_expr_p (arg0))
        return fold_build2 (MULT_EXPR, type,
-                           negate_expr (arg0),
-                           TREE_OPERAND (arg1, 0));
+                           fold_convert (type, negate_expr (arg0)),
+                           fold_convert (type, TREE_OPERAND (arg1, 0)));
 
       if (! FLOAT_TYPE_P (type))
        {

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 02e6dd1f7080398c0122edbd8313a7ba2e9538ad..e40ce0bfe09ad81faef50ab1ed6bd2365b91e26f 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2006-07-05  Richard Guenther  <rguenther@suse.de>
+
+       PR tree-optimization/28162
+       * gcc.dg/pr28162.c: New testcase.
+
 2006-07-05  Richard Guenther  <rguenther@suse.de>
        Andrew Pinski  <pinskia@gcc.gnu.org>
 

diff --git a/gcc/testsuite/gcc.dg/pr28162.c b/gcc/testsuite/gcc.dg/pr28162.c
new file mode 100644 (file)
index 0000000..8bd28ad
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr28162.c
@@ -0,0 +1,17 @@
+/* { dg-do compile } */
+/* { dg-options "-O3" } */
+
+void Lag_max_wght(float corr[], long wght_flg)
+{
+     float t0, max;
+     const float *ww;
+     long i;
+     if ( wght_flg > 0 ) {
+        for ( i = 143; i >= 20; i-- ) {
+           t0 = corr[ - i] * *ww--;
+           if ( t0 >= max )
+             max = t0;
+        }
+     }
+}
+