]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
NFSD: Remove unused values from nfsd4_encode_components_esc()
authorChuck Lever <chuck.lever@oracle.com>
Thu, 17 Oct 2024 15:03:55 +0000 (11:03 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Tue, 19 Nov 2024 01:23:02 +0000 (20:23 -0500)
Clean up. The computed value of @p is saved each time through the
loop but is never used.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index a3a0d27e51e60ae3765c8fe5f38a8005012bd2ff..53fac037611c05ff8ba2618f9e324a9cb54c3890 100644 (file)
@@ -2652,13 +2652,10 @@ static __be32 nfsd4_encode_components_esc(struct xdr_stream *xdr, char sep,
 
                strlen = end - str;
                if (strlen) {
-                       p = xdr_reserve_space(xdr, strlen + 4);
-                       if (!p)
+                       if (xdr_stream_encode_opaque(xdr, str, strlen) < 0)
                                return nfserr_resource;
-                       p = xdr_encode_opaque(p, str, strlen);
                        count++;
-               }
-               else
+               } else
                        end++;
                if (found_esc)
                        end = next;