gdb, gdbserver, gdbsupport: remove -Wno-vla-cxx-extension

Now that all known uses of VLAs within GDB are removed, remove the
`-Wno-vla-cxx-extension` (which was used to silence clang warnings) and
add `-Wvla`, such that any use of a VLA will trigger a warning.

Change-Id: I69a8d7f93f973743165b0ba46f9c2ea8adb89025
Reviewed-By: Keith Seitz <keiths@redhat.com>

diff --git a/gdb/configure b/gdb/configure
index 15ececfefa26a8cce2febce0d06a3e1ecbeb944a..62deef2f34155ecd36acc7b1a1524e2e10c8f0bb 100755 (executable)
--- a/gdb/configure
+++ b/gdb/configure
@@ -31188,7 +31188,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wredundant-move \
 -Wmissing-declarations \
 -Wstrict-null-sentinel \
--Wno-vla-cxx-extension \
+-Wvla \
 "
 
 # The -Wmissing-prototypes flag will be accepted by GCC, but results

diff --git a/gdbserver/configure b/gdbserver/configure
index 3abc647acda3538b65fa5f5ef00d6403e7703384..8d38b957e4159f67bf41897c57abb9c88e94ce2c 100755 (executable)
--- a/gdbserver/configure
+++ b/gdbserver/configure
@@ -13715,7 +13715,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wredundant-move \
 -Wmissing-declarations \
 -Wstrict-null-sentinel \
--Wno-vla-cxx-extension \
+-Wvla \
 "
 
 # The -Wmissing-prototypes flag will be accepted by GCC, but results

diff --git a/gdbsupport/configure b/gdbsupport/configure
index 19b19c42c6f39a2ae2dfca7e0823c16f162b9971..54e32bbe2cdd2deb931e9a75d49ed7842d7fca2d 100755 (executable)
--- a/gdbsupport/configure
+++ b/gdbsupport/configure
@@ -14188,7 +14188,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wredundant-move \
 -Wmissing-declarations \
 -Wstrict-null-sentinel \
--Wno-vla-cxx-extension \
+-Wvla \
 "
 
 # The -Wmissing-prototypes flag will be accepted by GCC, but results

diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4
index d12bccbd3fb9681fdeb599f39da71f0900f70f1e..2dadd7f99fd1a4a8b4084f78388bde5a9c32b9fd 100644 (file)
--- a/gdbsupport/warning.m4
+++ b/gdbsupport/warning.m4
@@ -52,7 +52,7 @@ build_warnings="-Wall -Wpointer-arith \
 -Wredundant-move \
 -Wmissing-declarations \
 -Wstrict-null-sentinel \
--Wno-vla-cxx-extension \
+-Wvla \
 "
 
 # The -Wmissing-prototypes flag will be accepted by GCC, but results