]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[5077] Addressed two additional review comments.
authorMarcin Siodelski <marcin@isc.org>
Mon, 19 Dec 2016 13:41:56 +0000 (14:41 +0100)
committerMarcin Siodelski <marcin@isc.org>
Mon, 19 Dec 2016 13:41:56 +0000 (14:41 +0100)
- Type cast to char, rather than uint8_t
- Return tag in the doxygen documentation

src/lib/http/request.h
src/lib/http/request_parser.cc

index a535f45410769e4baba87f603d904dd23cf4b114..e60e1e7314354b84e0c064bdf738595d1e71cec0 100644 (file)
@@ -78,6 +78,8 @@ public:
     ///
     /// This method is called by the @ref HttpRequestParser to retrieve the
     /// context in which parsed data is stored.
+    ///
+    /// @return Pointer to the underlying @ref HttpRequestContext.
     const HttpRequestContextPtr& context() const {
         return (context_);
     }
index 0968acd7fd3d4631767aa4afcc14903d9817b3d2..1e2847c03f4fd78bf42ea86d1ba7a963435518cd 100644 (file)
@@ -97,8 +97,8 @@ HttpRequestParser::postBuffer(const void* buf, const size_t buf_size) {
         if (getNextEvent() == NEED_MORE_DATA_EVT) {
             transition(getCurrState(), MORE_DATA_PROVIDED_EVT);
         }
-        buffer_.insert(buffer_.end(), static_cast<const uint8_t*>(buf),
-                       static_cast<const uint8_t*>(buf) + buf_size);
+        buffer_.insert(buffer_.end(), static_cast<const char*>(buf),
+                       static_cast<const char*>(buf) + buf_size);
     }
 }