* tcl_kadm5.c: don't assume tl_data_contents is null-terminated,

 	and zero allocated princ before parsing it

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@9326 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/kadmin/testing/util/ChangeLog b/src/kadmin/testing/util/ChangeLog
index ab44c96d9088cfcf82db56df979de78ca52d513e..b3c2ee1ef9f74a5bd21b93a4de3aa0f37fa6265c 100644 (file)
--- a/src/kadmin/testing/util/ChangeLog
+++ b/src/kadmin/testing/util/ChangeLog
@@ -1,3 +1,8 @@
+Thu Nov  7 13:09:33 1996  Barry Jaspan  <bjaspan@mit.edu>
+
+       * tcl_kadm5.c: don't assume tl_data_contents is null-terminated,
+       and zero allocated princ before parsing it
+
 Thu Nov  7 11:36:15 1996  Ezra Peisach  <epeisach@mit.edu>
 
        * tcl_kadm5.c (parse_keysalts, parse_tl_data): Do not free memory

diff --git a/src/kadmin/testing/util/tcl_kadm5.c b/src/kadmin/testing/util/tcl_kadm5.c
index e3a4d9aa1217f23c1773473f0c2e637d917d159b..9fac7244b02ff9f4aa0d6f30c6df0727835fddd0 100644 (file)
--- a/src/kadmin/testing/util/tcl_kadm5.c
+++ b/src/kadmin/testing/util/tcl_kadm5.c
@@ -483,7 +483,9 @@ static Tcl_DString *unparse_tl_data(krb5_tl_data *tl_data, int n_tl_data)
          Tcl_DStringAppendElement(str, buf);
          sprintf(buf, "%d", tl_data->tl_data_length);
          Tcl_DStringAppendElement(str, buf);
-         Tcl_DStringAppendElement(str, tl_data->tl_data_contents);
+         Tcl_DStringAppend(str, " ", 1);
+         Tcl_DStringAppend(str, tl_data->tl_data_contents,
+                           tl_data->tl_data_length);
          Tcl_DStringEndSublist(str);
      }
      Tcl_DStringEndSublist(str);
@@ -1130,7 +1132,8 @@ static int parse_principal_ent(Tcl_Interp *interp, char *list,
          fprintf(stderr, "Out of memory!\n");
          exit(1); /* XXX */
      }
-  
+     memset(princ, 0, sizeof(*princ));
+     
      if ((krb5_ret = krb5_parse_name(context, argv[0], &princ->principal)) != 0) {
          stash_error(interp, krb5_ret);
          Tcl_AppendElement(interp, "while parsing principal");