media: aspeed-video: address a protential usage of an unitialized var

While this might not occur in practice, if the device is doing
the right thing, it would be teoretically be possible to have
both hsync_counter and vsync_counter negatives.

If this ever happen, ctrl will be undefined, but the driver
will still call:

	aspeed_video_update(video, VE_CTRL, 0, ctrl);

Change the code to prevent this to happen.

This was warned by cppcheck:

	[drivers/media/platform/aspeed-video.c:653]: (error) Uninitialized variable: ctrl

Reviewed-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
index 94f97d96dabc85f6393e3e8d9cd5d3df17528c55..eb12f37930629983a06a43eeac0958e7228f2503 100644 (file)
--- a/drivers/media/platform/aspeed-video.c
+++ b/drivers/media/platform/aspeed-video.c
@@ -630,7 +630,7 @@ static void aspeed_video_check_and_set_polarity(struct aspeed_video *video)
        }
 
        if (hsync_counter < 0 || vsync_counter < 0) {
-               u32 ctrl;
+               u32 ctrl = 0;
 
                if (hsync_counter < 0) {
                        ctrl = VE_CTRL_HSYNC_POL;
@@ -650,7 +650,8 @@ static void aspeed_video_check_and_set_polarity(struct aspeed_video *video)
                                V4L2_DV_VSYNC_POS_POL;
                }
 
-               aspeed_video_update(video, VE_CTRL, 0, ctrl);
+               if (ctrl)
+                       aspeed_video_update(video, VE_CTRL, 0, ctrl);
        }
 }