]> git.ipfire.org Git - thirdparty/git.git/commitdiff
fsmonitor OSX: compile with DC_SHA1=YesPlease
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Wed, 19 Oct 2022 01:03:19 +0000 (03:03 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 19 Oct 2022 16:34:47 +0000 (09:34 -0700)
As we'll address in subsequent commits the "DC_SHA1=YesPlease" is not
on by default on OSX, instead we use Apple Common Crypto's SHA-1
implementation.

In 6beb2688d33 (fsmonitor: relocate socket file if .git directory is
remote, 2022-10-04) the build was broken with "DC_SHA1=YesPlease" (and
probably other non-"APPLE_COMMON_CRYPTO" SHA-1 backends).

So let's extract the fix for this from [1] to get the build working
again with "DC_SHA1=YesPlease". In addition to the fix in [1] we also
need to replace "SHA_DIGEST_LENGTH" with "GIT_MAX_RAWSZ".

1. https://lore.kernel.org/git/c085fc15b314abcb5e5ca6b4ee5ac54a28327cab.1665326258.git.gitgitgadget@gmail.com/

Signed-off-by: Eric DeCosta <edecosta@mathworks.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
compat/fsmonitor/fsm-ipc-darwin.c

index ce843d63348b46417876afc1e6aafe4ced85ff91..d67b0ee50d351682f2a9e5e80c3164fa601f65e6 100644 (file)
@@ -10,10 +10,10 @@ static GIT_PATH_FUNC(fsmonitor_ipc__get_default_path, "fsmonitor--daemon.ipc")
 const char *fsmonitor_ipc__get_path(struct repository *r)
 {
        static const char *ipc_path = NULL;
-       SHA_CTX sha1ctx;
+       git_SHA_CTX sha1ctx;
        char *sock_dir = NULL;
        struct strbuf ipc_file = STRBUF_INIT;
-       unsigned char hash[SHA_DIGEST_LENGTH];
+       unsigned char hash[GIT_MAX_RAWSZ];
 
        if (!r)
                BUG("No repository passed into fsmonitor_ipc__get_path");
@@ -28,9 +28,9 @@ const char *fsmonitor_ipc__get_path(struct repository *r)
                return ipc_path;
        }
 
-       SHA1_Init(&sha1ctx);
-       SHA1_Update(&sha1ctx, r->worktree, strlen(r->worktree));
-       SHA1_Final(hash, &sha1ctx);
+       git_SHA1_Init(&sha1ctx);
+       git_SHA1_Update(&sha1ctx, r->worktree, strlen(r->worktree));
+       git_SHA1_Final(hash, &sha1ctx);
 
        repo_config_get_string(r, "fsmonitor.socketdir", &sock_dir);