]> git.ipfire.org Git - thirdparty/git.git/commitdiff
add: use unsigned type for collection of bits
authorEugenio Gigante <giganteeugenio2@gmail.com>
Thu, 29 Feb 2024 19:44:44 +0000 (20:44 +0100)
committerJunio C Hamano <gitster@pobox.com>
Thu, 29 Feb 2024 19:52:42 +0000 (11:52 -0800)
The 'refresh' function in 'builtin/add.c' declares 'flags' as
signed, and passes it as an argument to the 'refresh_index'
function, which though expects an unsigned value.

Since in this case 'flags' represents a bag of bits, whose MSB is
not used in special ways, change the type of 'flags' to unsigned.

Signed-off-by: Eugenio Gigante <giganteeugenio2@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/add.c

index 2151c45fbf097253af1b56d34622f69f06921456..012d151252730e3302759ed52f741647e5ca4031 100644 (file)
@@ -115,7 +115,7 @@ static int refresh(int verbose, const struct pathspec *pathspec)
        int i, ret = 0;
        char *skip_worktree_seen = NULL;
        struct string_list only_match_skip_worktree = STRING_LIST_INIT_NODUP;
-       int flags = REFRESH_IGNORE_SKIP_WORKTREE |
+       unsigned int flags = REFRESH_IGNORE_SKIP_WORKTREE |
                    (verbose ? REFRESH_IN_PORCELAIN : REFRESH_QUIET);
 
        seen = xcalloc(pathspec->nr, 1);