]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virsh: Annotate "unwanted_positional" arguments for 'pool-(define|create)-as' commands
authorPeter Krempa <pkrempa@redhat.com>
Wed, 13 Mar 2024 21:54:05 +0000 (22:54 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 2 Apr 2024 12:24:30 +0000 (14:24 +0200)
Annotate arguments which can be unintentionally parsed positionally.
(See previous commits for explanation.)

All of these options were added in order thus we must declare all of
them as 'unwanted_positional'.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tools/virsh-pool.c

index 67cc1b94cf07b910b18b2bc6ee691775ae709682..66f8516017ba3a20631730120de66b33db017338 100644 (file)
     }, \
     {.name = "source-host", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .completer = virshCompleteEmpty, \
      .help = N_("source-host for underlying storage") \
     }, \
     {.name = "source-path", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("source path for underlying storage") \
     }, \
     {.name = "source-dev", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("source device for underlying storage") \
     }, \
     {.name = "source-name", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("source name for underlying storage") \
     }, \
     {.name = "target", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("target for underlying storage") \
     }, \
     {.name = "source-format", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("format for underlying storage") \
     }, \
     {.name = "auth-type", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("auth type to be used for underlying storage") \
     }, \
     {.name = "auth-username", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .completer = virshCompleteEmpty, \
      .help = N_("auth username to be used for underlying storage") \
     }, \
     {.name = "secret-usage", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("auth secret usage to be used for underlying storage") \
     }, \
     {.name = "secret-uuid", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("auth secret UUID to be used for underlying storage") \
     }, \
     {.name = "adapter-name", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("adapter name to be used for underlying storage") \
     }, \
     {.name = "adapter-wwnn", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("adapter wwnn to be used for underlying storage") \
     }, \
     {.name = "adapter-wwpn", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("adapter wwpn to be used for underlying storage") \
     }, \
     {.name = "adapter-parent", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("adapter parent scsi_hostN to be used for underlying vHBA storage") \
     }, \
     {.name = "adapter-parent-wwnn", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("adapter parent scsi_hostN wwnn to be used for underlying vHBA storage") \
     }, \
     {.name = "adapter-parent-wwpn", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("adapter parent scsi_hostN wwpn to be used for underlying vHBA storage") \
     }, \
     {.name = "adapter-parent-fabric-wwn", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("adapter parent scsi_hostN fabric_wwn to be used for underlying vHBA storage") \
     }, \
     {.name = "source-protocol-ver", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .help = N_("nfsvers value for NFS pool mount option") \
     }, \
     {.name = "source-initiator", \
      .type = VSH_OT_STRING, \
+     .unwanted_positional = true, \
      .completer = virshCompleteEmpty, \
      .help = N_("initiator iqn for underlying storage") \
     }