]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
hwmon: (spd5118) Use generic parity calculation
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 7 Jan 2025 09:02:00 +0000 (10:02 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 12 Jan 2025 22:55:50 +0000 (23:55 +0100)
Make use of the new generic helper for calculating the parity.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Link: https://lore.kernel.org/r/20250107090204.6593-3-wsa+renesas@sang-engineering.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/hwmon/spd5118.c

index 6cee48a3e5c33e62073dcaa47c916363f79f469d..358152868d961b8a37d481abf500b694f3f5540e 100644 (file)
@@ -291,12 +291,6 @@ static umode_t spd5118_is_visible(const void *_data, enum hwmon_sensor_types typ
        }
 }
 
-static inline bool spd5118_parity8(u8 w)
-{
-       w ^= w >> 4;
-       return (0x6996 >> (w & 0xf)) & 1;
-}
-
 /*
  * Bank and vendor id are 8-bit fields with seven data bits and odd parity.
  * Vendor IDs 0 and 0x7f are invalid.
@@ -304,7 +298,7 @@ static inline bool spd5118_parity8(u8 w)
  */
 static bool spd5118_vendor_valid(u8 bank, u8 id)
 {
-       if (!spd5118_parity8(bank) || !spd5118_parity8(id))
+       if (parity8(bank) == 0 || parity8(id) == 0)
                return false;
 
        id &= 0x7f;