smbd: TALLOC_FREE(sd) where it was allocated

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index e61b50b38014dafd30cafeee397d42dca954adb9..b87b74988ae4664fb7bb169794c2828da4c23da9 100644 (file)
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -198,8 +198,6 @@ static NTSTATUS smbd_check_access_rights_sd(
                }
        }
 
-       TALLOC_FREE(sd);
-
        if (NT_STATUS_IS_OK(status) ||
            !NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED))
        {
@@ -327,13 +325,15 @@ NTSTATUS smbd_check_access_rights_fsp(struct files_struct *dirfsp,
                return status;
        }
 
-       return smbd_check_access_rights_sd(fsp->conn,
-                                          dirfsp,
-                                          fsp->fsp_name,
-                                          sd,
-                                          use_privs,
-                                          access_mask,
-                                          do_not_check_mask);
+       status = smbd_check_access_rights_sd(fsp->conn,
+                                            dirfsp,
+                                            fsp->fsp_name,
+                                            sd,
+                                            use_privs,
+                                            access_mask,
+                                            do_not_check_mask);
+       TALLOC_FREE(sd);
+       return status;
 }
 
 /*