]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: imu: adis16480: make use of irq_get_trigger_type()
authorNuno Sa <nuno.sa@analog.com>
Wed, 17 Jan 2024 13:10:51 +0000 (14:10 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 17 Feb 2024 16:16:09 +0000 (16:16 +0000)
There's no need to call both irq_get_irq_data() and
irqd_get_trigger_type() as we already have an helper for that. This
allows for code simplification.

Signed-off-by: Nuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20240117-adis-improv-v1-3-7f90e9fad200@analog.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/adis16480.c

index fe520194a837177b758a28ff5edbbd6a5852693b..b40a55bba30c191dd83fa1664a9b87eeba8c2731 100644 (file)
@@ -1246,18 +1246,11 @@ static int adis16480_config_irq_pin(struct adis16480 *st)
 {
        struct device *dev = &st->adis.spi->dev;
        struct fwnode_handle *fwnode = dev_fwnode(dev);
-       struct irq_data *desc;
        enum adis16480_int_pin pin;
        unsigned int irq_type;
        uint16_t val;
        int i, irq = 0;
 
-       desc = irq_get_irq_data(st->adis.spi->irq);
-       if (!desc) {
-               dev_err(dev, "Could not find IRQ %d\n", irq);
-               return -EINVAL;
-       }
-
        /* Disable data ready since the default after reset is on */
        val = ADIS16480_DRDY_EN(0);
 
@@ -1285,7 +1278,7 @@ static int adis16480_config_irq_pin(struct adis16480 *st)
         * configured as positive or negative, corresponding to
         * IRQ_TYPE_EDGE_RISING or IRQ_TYPE_EDGE_FALLING respectively.
         */
-       irq_type = irqd_get_trigger_type(desc);
+       irq_type = irq_get_trigger_type(st->adis.spi->irq);
        if (irq_type == IRQ_TYPE_EDGE_RISING) { /* Default */
                val |= ADIS16480_DRDY_POL(1);
        } else if (irq_type == IRQ_TYPE_EDGE_FALLING) {