[image] Move embedded images from .rodata to .data

Decrypting a CMS-encrypted image will overwrite the existing image
data in place, and using an encrypted embedded image is a valid use
case.

Move embedded images from .rodata to .data to reflect the fact that
they are intended to be writable.

Signed-off-by: Michael Brown <mcb30@ipxe.org>

diff --git a/src/image/embedded.c b/src/image/embedded.c
index 3c4bee65520219d2d1024b253362836ff1045c0b..58833ac30b4b4da934396fd2fc094214c24a85d5 100644 (file)
--- a/src/image/embedded.c
+++ b/src/image/embedded.c
@@ -18,7 +18,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
 #define EMBED( _index, _path, _name )                                  \
        extern char embedded_image_ ## _index ## _data[];               \
        extern char embedded_image_ ## _index ## _len[];                \
-       __asm__ ( ".section \".rodata\", \"a\", " PROGBITS "\n\t"       \
+       __asm__ ( ".section \".data\", \"aw\", " PROGBITS "\n\t"        \
                  "\nembedded_image_" #_index "_data:\n\t"              \
                  ".incbin \"" _path "\"\n\t"                           \
                  "\nembedded_image_" #_index "_end:\n\t"               \