]> git.ipfire.org Git - thirdparty/ipxe.git/commitdiff
[efi] Remove spurious close of SNP device parent's device path
authorMichael Brown <mcb30@ipxe.org>
Sun, 23 Mar 2025 18:22:00 +0000 (18:22 +0000)
committerMichael Brown <mcb30@ipxe.org>
Sun, 23 Mar 2025 18:24:10 +0000 (18:24 +0000)
Commit e727f57 ("[efi] Include a copy of the device path within struct
efi_device") neglected to delete the closure of the parent's device
path from the success code path in efi_snp_probe().

Reduce confusion by removing this (harmless) additional close.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/interface/efi/efi_snp.c

index 8443be997eff6ae032b135b0fe7837916fd0cf5f..d977802fd70ad3dd2bac57634b1b43ee5e672b0c 100644 (file)
@@ -1958,10 +1958,6 @@ static int efi_snp_probe ( struct net_device *netdev, void *priv __unused ) {
        /* Add to list of SNP devices */
        list_add ( &snpdev->list, &efi_snp_devices );
 
-       /* Close device path */
-       bs->CloseProtocol ( efidev->device, &efi_device_path_protocol_guid,
-                           efi_image_handle, efidev->device );
-
        DBGC ( snpdev, "SNPDEV %p installed for %s as device %s\n",
               snpdev, netdev->name, efi_handle_name ( snpdev->handle ) );
        return 0;