]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t/perf/fsmonitor: improve error message if typoing hook name
authorNipunn Koorapati <nipunn@dropbox.com>
Mon, 26 Oct 2020 19:32:46 +0000 (19:32 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 26 Oct 2020 23:39:33 +0000 (16:39 -0700)
Previously - it would silently run the perf suite w/o using
fsmonitor - fsmonitor errors are not hard failures.
Now it errors loudly.

GIT_PERF_7519_FSMONITOR="$HOME/rs-git-fsmonitorr"
./p7519-fsmonitor.sh -i -v

fatal: cannot run /home/nipunn/rs-git-fsmonitorr:
No such file or directory
not ok 2 - setup for fsmonitor

Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/perf/p7519-fsmonitor.sh

index 4030f569cf624bee7113cfd13d789474a7bfe6e1..88b3717e2a8ec2533474b695be99e4707116208a 100755 (executable)
@@ -126,7 +126,9 @@ test_expect_success "setup for fsmonitor" '
        fi &&
 
        git config core.fsmonitor "$INTEGRATION_SCRIPT" &&
-       git update-index --fsmonitor &&
+       git update-index --fsmonitor 2>error &&
+       cat error &&
+       [ ! -s error ] && # ensure no silent error
        git status  # Warm caches
 '