]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
staging: nvec: Use IRQF_NO_AUTOEN flag in request_irq()
authorJinjie Ruan <ruanjinjie@huawei.com>
Thu, 12 Sep 2024 03:17:31 +0000 (11:17 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 13 Sep 2024 05:30:23 +0000 (07:30 +0200)
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20240912031731.2211698-1-ruanjinjie@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/nvec/nvec.c

index bf7a61f05b06bb8b379d3c416a6f6b8c97915dd4..977f8fc29e631f1a391da08531a51a98c4a0e443 100644 (file)
@@ -845,13 +845,12 @@ static int tegra_nvec_probe(struct platform_device *pdev)
                return PTR_ERR(nvec->gpiod);
        }
 
-       err = devm_request_irq(dev, nvec->irq, nvec_interrupt, 0,
+       err = devm_request_irq(dev, nvec->irq, nvec_interrupt, IRQF_NO_AUTOEN,
                               "nvec", nvec);
        if (err) {
                dev_err(dev, "couldn't request irq\n");
                return -ENODEV;
        }
-       disable_irq(nvec->irq);
 
        tegra_init_i2c_slave(nvec);