imap-urlauth: client_destroy() - Allow NULL reason only if client is disconnected

diff --git a/src/imap-urlauth/imap-urlauth-client.c b/src/imap-urlauth/imap-urlauth-client.c
index 75af94d1aff8fee8dcd1ef59733a7d019b397f06..c5e82a811cebcad63e0e140221f11f70b5a19e36 100644 (file)
--- a/src/imap-urlauth/imap-urlauth-client.c
+++ b/src/imap-urlauth/imap-urlauth-client.c
@@ -328,13 +328,12 @@ void client_worker_input(struct client *client)
 
 void client_destroy(struct client *client, const char *reason)
 {
+       i_assert(reason != NULL || client->disconnected);
+
        i_set_failure_prefix("%s: ", master_service_get_name(master_service));
 
-       if (!client->disconnected) {
-               if (reason == NULL)
-                       reason = "Connection closed";
+       if (!client->disconnected)
                i_info("Disconnected: %s", reason);
-       }
 
        imap_urlauth_client_count--;
        DLLIST_REMOVE(&imap_urlauth_clients, client);