]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
smb: server: remove useless casts from KSMBD_TRANS/SMBD_TRANS
authorStefan Metzmacher <metze@samba.org>
Fri, 15 Aug 2025 11:04:31 +0000 (13:04 +0200)
committerSteve French <stfrench@microsoft.com>
Sun, 28 Sep 2025 23:29:52 +0000 (18:29 -0500)
At best they gain nothing, at worst we procude real bugs.
Note container_of() already casts to a pointer of the
given type.

Cc: Namjae Jeon <linkinjeon@kernel.org>
Cc: Steve French <smfrench@gmail.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: linux-cifs@vger.kernel.org
Cc: samba-technical@lists.samba.org
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/transport_rdma.c

index 11fed588fcc0861bc110352ed509adaf4414e0a0..0abcf2991c3c0dbf81be5710acfb9bb3a7396e68 100644 (file)
@@ -99,8 +99,8 @@ struct smb_direct_transport {
        u8                      responder_resources;
 };
 
-#define KSMBD_TRANS(t) ((struct ksmbd_transport *)&((t)->transport))
-#define SMBD_TRANS(t)  ((struct smb_direct_transport *)container_of(t, \
+#define KSMBD_TRANS(t) (&(t)->transport)
+#define SMBD_TRANS(t)  (container_of(t, \
                                struct smb_direct_transport, transport))
 
 static const struct ksmbd_transport_ops ksmbd_smb_direct_transport_ops;