]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
thermal: netlink: Fix parameter type of thermal_genl_cpu_capability_event() stub
authorNathan Chancellor <nathan@kernel.org>
Mon, 7 Feb 2022 16:38:29 +0000 (09:38 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 7 Feb 2022 19:45:42 +0000 (20:45 +0100)
When building with CONFIG_THERMAL_NETLINK=n, there is a spew of warnings
along the lines of:

  In file included from drivers/thermal/thermal_core.c:27:
  In file included from drivers/thermal/thermal_core.h:15:
  drivers/thermal/thermal_netlink.h:113:71: warning: declaration of 'struct cpu_capability' will not be visible outside of this function [-Wvisibility]
  static inline int thermal_genl_cpu_capability_event(int count, struct cpu_capability *caps)
                                                                        ^
  1 warning generated.

'struct cpu_capability' is not forward declared anywhere in the header.
As it turns out, this should really be 'struct thermal_genl_cpu_caps',
which silences the warning and makes the parameter types of the stub
match the full function.

Fixes: e4b1eb24ce5a ("thermal: netlink: Add a new event to notify CPU capabilities change")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/thermal_netlink.h

index 04d1adbbc01246f7edf1b681b1f1ac84d0fec8d4..1052f523188dab9dd4d1f3c0cfa95a1d195f41e3 100644 (file)
@@ -110,7 +110,7 @@ static inline int thermal_genl_sampling_temp(int id, int temp)
        return 0;
 }
 
-static inline int thermal_genl_cpu_capability_event(int count, struct cpu_capability *caps)
+static inline int thermal_genl_cpu_capability_event(int count, struct thermal_genl_cpu_caps *caps)
 {
        return 0;
 }