]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/radeon: initialize backlight for iMac12,2 with Radeon 6750M
authorKendall Smith <kendallsm2@icloud.com>
Wed, 15 May 2024 19:20:09 +0000 (15:20 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 17 May 2024 21:40:38 +0000 (17:40 -0400)
If a Radeon 6750M GPU from an iMac12,1 is installed into an
iMac 12,2, there is no backlight device initialized during
boot. Everything else is functional, but the display brightness
cannot be controlled. There are no directories present in
/sys/class/backlight after booting. A simple one line
modification to an if statement fixes this issue by initializing
the radeon backlight device for an iMac12,2 as well if it has a
6750M. After the patch, brightness can be controlled and
radeon_bl0 is present in /sys/class/backlight. This was tested
by compiling the latest kernel with and without the patch.

Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3378
Signed-off-by: Kendall Smith <kendallsm2@icloud.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/atombios_encoders.c

index 2bff0d9e20f530f7ea62a86d06530459c6d2ecb9..7b11674f5d45add984fefb25ea5bfa961a624f09 100644 (file)
@@ -201,7 +201,7 @@ void radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder,
         */
        if ((rdev->pdev->subsystem_vendor == PCI_VENDOR_ID_APPLE) &&
            (rdev->pdev->device == 0x6741) &&
-           !dmi_match(DMI_PRODUCT_NAME, "iMac12,1"))
+           !(dmi_match(DMI_PRODUCT_NAME, "iMac12,1") || dmi_match(DMI_PRODUCT_NAME, "iMac12,2")))
                return;
 
        if (!radeon_encoder->enc_priv)