]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: qla2xxx: Fix optrom version displayed in FDMI
authorShreyas Deodhar <sdeodhar@marvell.com>
Wed, 10 Jul 2024 17:10:54 +0000 (22:40 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 11 Jul 2024 02:44:10 +0000 (22:44 -0400)
Bios version was popluated for FDMI response. Systems with EFI would show
optrom version as 0.  EFI version is populated here and BIOS version is
already displayed under FDMI_HBA_BOOT_BIOS_NAME.

Cc: stable@vger.kernel.org
Signed-off-by: Shreyas Deodhar <sdeodhar@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20240710171057.35066-9-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_gs.c

index e801cd9e2345953bb0dc967f4409e2683b9c4835..caa9a3cd2580c0afd76ae889bcd6296664287470 100644 (file)
@@ -1710,7 +1710,7 @@ qla2x00_hba_attributes(scsi_qla_host_t *vha, void *entries,
        eiter->type = cpu_to_be16(FDMI_HBA_OPTION_ROM_VERSION);
        alen = scnprintf(
                eiter->a.orom_version, sizeof(eiter->a.orom_version),
-               "%d.%02d", ha->bios_revision[1], ha->bios_revision[0]);
+               "%d.%02d", ha->efi_revision[1], ha->efi_revision[0]);
        alen += FDMI_ATTR_ALIGNMENT(alen);
        alen += FDMI_ATTR_TYPELEN(eiter);
        eiter->len = cpu_to_be16(alen);