]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: drop ranges in definition of ARCH_FORCE_MAX_ORDER
authorMike Rapoport (IBM) <rppt@kernel.org>
Fri, 24 Mar 2023 05:22:21 +0000 (08:22 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 18 Apr 2023 23:29:44 +0000 (16:29 -0700)
It is not a good idea to change fundamental parameters of core memory
management.  Having predefined ranges suggests that the values within
those ranges are sensible, but one has to *really* understand implications
of changing MAX_ORDER before actually amending it and ranges don't help
here.

Drop ranges in definition of ARCH_FORCE_MAX_ORDER and make its prompt
visible only if EXPERT=y

Link: https://lkml.kernel.org/r/20230324052233.2654090-3-rppt@kernel.org
Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: David Miller <davem@davemloft.net>
Cc: Dinh Nguyen <dinguyen@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Guo Ren <guoren@kernel.org>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Rich Felker <dalias@libc.org>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Will Deacon <will@kernel.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
arch/arm64/Kconfig

index e60baf7859d1ce90af012cea86a07be4ea662762..7324032af859034abfab4f53e2042f35a3cc73ce 100644 (file)
@@ -1487,11 +1487,9 @@ config XEN
 # 16K |       27          |      14      |       13        |         11         |
 # 64K |       29          |      16      |       13        |         13         |
 config ARCH_FORCE_MAX_ORDER
-       int "Maximum zone order" if ARM64_4K_PAGES || ARM64_16K_PAGES
+       int "Maximum zone order" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PAGES)
        default "13" if ARM64_64K_PAGES
-       range 11 13 if ARM64_16K_PAGES
        default "11" if ARM64_16K_PAGES
-       range 10 15 if ARM64_4K_PAGES
        default "10"
        help
          The kernel memory allocator divides physically contiguous memory