media: rkisp1: Use %pe format specifier

The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./platform/rockchip/rkisp1/rkisp1-isp.c:940:3-10: WARNING: Consider using %pe to print PTR_ERR()
./platform/rockchip/rkisp1/rkisp1-csi.c:372:3-10: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c
index 841e58c20f7fcb484643138627413425a049d1fa..ddc6182f3e4bdacdd1962c86f6259334b16aa505 100644 (file)
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c
@@ -368,8 +368,8 @@ static int rkisp1_csi_s_stream(struct v4l2_subdev *sd, int enable)
 
        source_pad = media_entity_remote_source_pad_unique(&sd->entity);
        if (IS_ERR(source_pad)) {
-               dev_dbg(rkisp1->dev, "Failed to get source for CSI: %ld\n",
-                       PTR_ERR(source_pad));
+               dev_dbg(rkisp1->dev, "Failed to get source for CSI: %pe\n",
+                       source_pad);
                return -EPIPE;
        }
 

diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
index 8c29a1c9309a846152d212dcb50b7bf991d4f422..147d33eb6ee0d975b257c5df2997b811ba3a62e1 100644 (file)
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
@@ -936,8 +936,8 @@ static int rkisp1_isp_s_stream(struct v4l2_subdev *sd, int enable)
        sink_pad = &isp->pads[RKISP1_ISP_PAD_SINK_VIDEO];
        source_pad = media_pad_remote_pad_unique(sink_pad);
        if (IS_ERR(source_pad)) {
-               dev_dbg(rkisp1->dev, "Failed to get source for ISP: %ld\n",
-                       PTR_ERR(source_pad));
+               dev_dbg(rkisp1->dev, "Failed to get source for ISP: %pe\n",
+                       source_pad);
                return -EPIPE;
        }