parser: Don't duplicate and leak arch

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/libpakfire/parser.c b/src/libpakfire/parser.c
index 54852dc84838ad7ed6edb1ef4f2e51dbb5b3aafc..2f158942925b8969bce123c1fa7a67fa06ea7c42 100644 (file)
--- a/src/libpakfire/parser.c
+++ b/src/libpakfire/parser.c
@@ -1030,19 +1030,15 @@ int pakfire_parser_create_package(struct pakfire_parser* parser,
        // Fetch arch
        arch = pakfire_parser_get(parser, namespace, "arch");
        if (!arch || !*arch) {
-               if (default_arch) {
-                       arch = strdup(default_arch);
-                       if (!arch)
-                               goto CLEANUP;
-               } else {
+               if (!default_arch) {
                        ERROR(parser->ctx, "Arch is empty\n");
                        goto CLEANUP;
                }
        }
 
        // Create a new package object
-       r = pakfire_package_create(pkg, parser->pakfire, repo, name, evr, arch);
-       if (r) {
+       r = pakfire_package_create(pkg, parser->pakfire, repo, name, evr, (arch) ? arch : default_arch);
+       if (r < 0) {
                ERROR(parser->ctx, "Could not create package: %m\n");
                goto CLEANUP;
        }