]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commitdiff
data_smart.py: don't reorder internal bitbake variables when calculating hash
authorPatrick Ohly <patrick.ohly@intel.com>
Mon, 14 Nov 2016 09:39:00 +0000 (10:39 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 23 Nov 2016 10:59:49 +0000 (10:59 +0000)
Commit 260ced745 added __BBTASKS, __BBANONFUNCS, __BBHANDLERS to the
data that gets hashed, but only after reordering these lists. The
intention probably was to make the hash deterministic, but that's
unnecessary (the content of the variables should already be
deterministic) and hides potential reasons that might require
re-parsing.

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
lib/bb/data_smart.py

index cd3853e736044dac646ad3fd3731cf415c0be525..b7badb6a3706b9a39dfe3d16aa961be3607eb6c2 100644 (file)
@@ -956,7 +956,6 @@ class DataSmart(MutableMapping):
 
         for key in ["__BBTASKS", "__BBANONFUNCS", "__BBHANDLERS"]:
             bb_list = d.getVar(key, False) or []
-            bb_list.sort()
             data.update({key:str(bb_list)})
 
             if key == "__BBANONFUNCS":