]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/nouveau/disp: Fix missing backlight control on Macbook 5,1
authorTakashi Iwai <tiwai@suse.de>
Thu, 2 Jan 2025 11:49:36 +0000 (12:49 +0100)
committerDanilo Krummrich <dakr@kernel.org>
Tue, 7 Jan 2025 14:45:55 +0000 (15:45 +0100)
Macbook 5,1 with MCP79 lost its backlight control since the recent
change for supporting GSP-RM; it rewrote the whole nv50 backlight
control code and each display engine is supposed to have an entry for
IOR bl callback, but it didn't cover mcp77.

This patch adds the missing bl entry initialization for mcp77 display
engine to recover the backlight control.

Fixes: 2274ce7e3681 ("drm/nouveau/disp: add output backlight control methods")
Cc: stable@vger.kernel.org
Link: https://bugzilla.suse.com/show_bug.cgi?id=1223838
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250102114944.11499-1-tiwai@suse.de
drivers/gpu/drm/nouveau/nvkm/engine/disp/mcp77.c

index 841e3b69fcaf3eac05153673dbc4bda2d1bf470c..5a0c9b8a79f3ecadcb0723549a7f4c9a5dd32eaa 100644 (file)
@@ -31,6 +31,7 @@ mcp77_sor = {
        .state = g94_sor_state,
        .power = nv50_sor_power,
        .clock = nv50_sor_clock,
+       .bl = &nv50_sor_bl,
        .hdmi = &g84_sor_hdmi,
        .dp = &g94_sor_dp,
 };