]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: ath12k: improve the rx descriptor error information
authorKarthikeyan Periyasamy <quic_periyasa@quicinc.com>
Tue, 21 May 2024 08:08:10 +0000 (11:08 +0300)
committerKalle Valo <quic_kvalo@quicinc.com>
Sat, 25 May 2024 08:54:42 +0000 (11:54 +0300)
The ath12k_dp_get_rx_desc() failure log currently contains the same
information across multiple Rx data paths and lacks sufficient detail for
debugging purposes. To address this, change the ath12k_dp_get_rx_desc()
failure log to include cookie information along with Rx path details.
This will provide more specific data for debugging purposes.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 HW2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240516000807.1704913-3-quic_periyasa@quicinc.com
drivers/net/wireless/ath/ath12k/dp_rx.c

index d8998ac3a482db6b8c4532d2269e6050afa0be08..000df6edf6b4e9041e041347f90b6d88cc0bea93 100644 (file)
@@ -2628,7 +2628,8 @@ try_again:
                if (!desc_info) {
                        desc_info = ath12k_dp_get_rx_desc(ab, cookie);
                        if (!desc_info) {
-                               ath12k_warn(ab, "Invalid cookie in manual desc retrieval");
+                               ath12k_warn(ab, "Invalid cookie in manual descriptor retrieval: 0x%x\n",
+                                           cookie);
                                continue;
                        }
                }
@@ -3326,7 +3327,8 @@ ath12k_dp_process_rx_err_buf(struct ath12k *ar, struct hal_reo_dest_ring *desc,
        if (!desc_info) {
                desc_info = ath12k_dp_get_rx_desc(ab, cookie);
                if (!desc_info) {
-                       ath12k_warn(ab, "Invalid cookie in manual desc retrieval");
+                       ath12k_warn(ab, "Invalid cookie in DP rx error descriptor retrieval: 0x%x\n",
+                                   cookie);
                        return -EINVAL;
                }
        }
@@ -3745,7 +3747,8 @@ int ath12k_dp_rx_process_wbm_err(struct ath12k_base *ab,
                if (!desc_info) {
                        desc_info = ath12k_dp_get_rx_desc(ab, err_info.cookie);
                        if (!desc_info) {
-                               ath12k_warn(ab, "Invalid cookie in manual desc retrieval");
+                               ath12k_warn(ab, "Invalid cookie in DP WBM rx error descriptor retrieval: 0x%x\n",
+                                           err_info.cookie);
                                continue;
                        }
                }