Fix memory leak from passphrase callback

There is a bug in the linked list implementation for passphrases. The insert to
head function does not account for the tail==head case and causes a leak. The
first entry into the list is lost when the second entry is added. The second
and beyond entries are are released properly, but the first is lost entirely.

diff --git a/libarchive/archive_read_add_passphrase.c b/libarchive/archive_read_add_passphrase.c
index cf821b5d483c630e11893a03841433cae2707e54..f0b1ab93300f8f124aa5dd82ab0a24965c385b14 100644 (file)
--- a/libarchive/archive_read_add_passphrase.c
+++ b/libarchive/archive_read_add_passphrase.c
@@ -57,6 +57,10 @@ insert_passphrase_to_head(struct archive_read *a,
 {
        p->next = a->passphrases.first;
        a->passphrases.first = p;
+       if (&a->passphrases.first == a->passphrases.last) {
+               a->passphrases.last = &p->next;
+               p->next = NULL;
+       }
 }
 
 static struct archive_read_passphrase *