]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
KVM: LoongArch: Mark "struct page" pfn accessed before dropping mmu_lock
authorSean Christopherson <seanjc@google.com>
Thu, 10 Oct 2024 18:24:09 +0000 (11:24 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 25 Oct 2024 17:00:49 +0000 (13:00 -0400)
Mark pages accessed before dropping mmu_lock when faulting in guest memory
so that LoongArch can convert to kvm_release_faultin_page() without
tripping its lockdep assertion on mmu_lock being held.

Reviewed-by: Bibo Mao <maobibo@loongson.cn>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <20241010182427.1434605-68-seanjc@google.com>

arch/loongarch/kvm/mmu.c

index ed43504c5c7e7fb7b1f51e72af1eaf80a4758ee1..7066cafcce6417fa285adb81171c4bd040bdd6c1 100644 (file)
@@ -902,13 +902,13 @@ retry:
 
        if (writeable)
                kvm_set_pfn_dirty(pfn);
+       kvm_release_pfn_clean(pfn);
 
        spin_unlock(&kvm->mmu_lock);
 
        if (prot_bits & _PAGE_DIRTY)
                mark_page_dirty_in_slot(kvm, memslot, gfn);
 
-       kvm_release_pfn_clean(pfn);
 out:
        srcu_read_unlock(&kvm->srcu, srcu_idx);
        return err;