]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI/P2PDMA: Constify 'struct bin_attribute'
authorThomas Weißschuh <linux@weissschuh.net>
Mon, 2 Dec 2024 19:02:59 +0000 (20:02 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 3 Dec 2024 21:29:59 +0000 (15:29 -0600)
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Link: https://lore.kernel.org/r/20241202-sysfs-const-bin_attr-pci-v1-3-c32360f495a7@weissschuh.net
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
drivers/pci/p2pdma.c

index 7abd4f546d3c071f31e622d881f5c5ac3e4de55e..0cb7e0aaba0ebdb8d0d235428a03a113cde7b390 100644 (file)
@@ -161,7 +161,7 @@ out:
        return ret;
 }
 
-static struct bin_attribute p2pmem_alloc_attr = {
+static const struct bin_attribute p2pmem_alloc_attr = {
        .attr = { .name = "allocate", .mode = 0660 },
        .mmap = p2pmem_alloc_mmap,
        /*
@@ -180,14 +180,14 @@ static struct attribute *p2pmem_attrs[] = {
        NULL,
 };
 
-static struct bin_attribute *p2pmem_bin_attrs[] = {
+static const struct bin_attribute *const p2pmem_bin_attrs[] = {
        &p2pmem_alloc_attr,
        NULL,
 };
 
 static const struct attribute_group p2pmem_group = {
        .attrs = p2pmem_attrs,
-       .bin_attrs = p2pmem_bin_attrs,
+       .bin_attrs_new = p2pmem_bin_attrs,
        .name = "p2pmem",
 };