]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
LoongArch: Fix ld --no-relax bug
authormengqinggang <mengqinggang@loongson.cn>
Thu, 16 Nov 2023 11:19:11 +0000 (19:19 +0800)
committerliuzhensong <liuzhensong@loongson.cn>
Fri, 17 Nov 2023 08:38:53 +0000 (16:38 +0800)
When calling ld with --no-relax, pcalau12i + ld.d still can be relaxed.
This patch fix this bug and pcalau12i + ld.d can be relaxed with --relax.

bfd/elfnn-loongarch.c

index 18ad3cc91cad5b7b4800a69f8aaa3f9421cc8b74..1162cb35cd6cf4a4eab7120e398d51ed409fd8e1 100644 (file)
@@ -3996,29 +3996,22 @@ loongarch_elf_relax_section (bfd *abfd, asection *sec,
            loongarch_relax_align (abfd, sec, sym_sec, info, rel, symval);
          break;
        case R_LARCH_DELETE:
-         if (info->relax_pass == 1)
+         if (1 == info->relax_pass)
            {
              loongarch_relax_delete_bytes (abfd, sec, rel->r_offset, 4, info);
              rel->r_info = ELFNN_R_INFO (0, R_LARCH_NONE);
            }
          break;
        case R_LARCH_PCALA_HI20:
-         if (info->relax_pass == 0)
-           {
-             if (i + 4 > sec->reloc_count)
-               break;
-             loongarch_relax_pcala_addi (abfd, sec, rel, symval);
-           }
+         if (0 == info->relax_pass && (i + 4) <= sec->reloc_count)
+           loongarch_relax_pcala_addi (abfd, sec, rel, symval);
          break;
        case R_LARCH_GOT_PC_HI20:
-         if (local_got)
+         if (local_got && 0 == info->relax_pass
+             && (i + 4) <= sec->reloc_count)
            {
-             if (i + 4 > sec->reloc_count)
-               break;
              if (loongarch_relax_pcala_ld (abfd, sec, rel))
-               {
-                 loongarch_relax_pcala_addi (abfd, sec, rel, symval);
-               }
+               loongarch_relax_pcala_addi (abfd, sec, rel, symval);
            }
          break;
        default: