Merge branch 'dl/push-missing-object-error'

"git push" had a code path that led to BUG() but it should have
been a die(), as it is a response to a usual but invalid end-user
action to attempt pushing an object that does not exist.

* dl/push-missing-object-error:
  remote.c: convert if-else ladder to switch
  remote.c: remove BUG in show_push_unqualified_ref_name_error()
  t5516: remove surrounding empty lines in test bodies

diff --cc remote.c
index f108458035da93190f823949f81657c7cf6a3a21,398bfa6a958e777ed7fd355a9dabd8107910146c..81d8fc017e1b3748cb7828c8d3682e78f4534260
--- 1/remote.c
--- 2/remote.c
+++ b/remote.c
@@@ -1196,8 -1181,9 +1195,9 @@@ static void show_push_unqualified_ref_n
                BUG("'%s' is not a valid object, "
                    "match_explicit_lhs() should catch this!",
                    matched_src_name);
-       type = odb_read_object_info(the_repository->objects, &oid, NULL);
-       if (type == OBJ_COMMIT) {
+ 
 -      switch (oid_object_info(the_repository, &oid, NULL)) {
++      switch (odb_read_object_info(the_repository->objects, &oid, NULL)) {
+       case OBJ_COMMIT:
                advise(_("The <src> part of the refspec is a commit object.\n"
                         "Did you mean to create a new branch by pushing to\n"
                         "'%s:refs/heads/%s'?"),

diff --cc t/t5516-fetch-push.sh
Simple merge