]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
udevConnectListAllInterfaces: delete pointless cleanup code
authorJán Tomko <jtomko@redhat.com>
Fri, 20 Nov 2020 13:10:58 +0000 (14:10 +0100)
committerJán Tomko <jtomko@redhat.com>
Tue, 1 Dec 2020 16:22:09 +0000 (17:22 +0100)
We only jump to cleanup before allocating any lists.

Drop the dead code.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/interface/interface_backend_udev.c

index 31246dde74482e206f52a67c3962917b65349fc0..173c4fc3f09411ecfdfb70e99c537d9065ce0eb1 100644 (file)
@@ -300,7 +300,6 @@ udevConnectListAllInterfaces(virConnectPtr conn,
     struct udev_list_entry *dev_entry;
     virInterfacePtr *ifaces_list = NULL;
     virInterfacePtr iface_obj;
-    int tmp_count;
     int count = 0;
     int status = 0;
     int ret = -1;
@@ -405,14 +404,6 @@ udevConnectListAllInterfaces(virConnectPtr conn,
     if (enumerate)
         udev_enumerate_unref(enumerate);
     udev_unref(udev);
-
-    if (ifaces) {
-        for (tmp_count = 0; tmp_count < count; tmp_count++)
-            virObjectUnref(ifaces_list[tmp_count]);
-    }
-
-    VIR_FREE(ifaces_list);
-
     return ret;
 
 }