]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
firmware_loader: EXTRA_FIRMWARE does not support compressed files
authorRandy Dunlap <rdunlap@infradead.org>
Mon, 14 Feb 2022 22:23:11 +0000 (14:23 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Feb 2022 11:14:42 +0000 (12:14 +0100)
Document in the firmware loader Kconfig help text that firmware image
file compression is not supported for builtin EXTRA_FIRMWARE files so
that someone does not waste time trying that.

Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20220214222311.9758-1-rdunlap@infradead.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_loader/Kconfig

index 5b24f39592557d082ecf999b23e0aa20528b88a7..38f3b66bf52b27457b0e571c286bae0565efec66 100644 (file)
@@ -60,6 +60,8 @@ config EXTRA_FIRMWARE
          image since it combines both GPL and non-GPL work. You should
          consult a lawyer of your own before distributing such an image.
 
+         NOTE: Compressed files are not supported in EXTRA_FIRMWARE.
+
 config EXTRA_FIRMWARE_DIR
        string "Firmware blobs root directory"
        depends on EXTRA_FIRMWARE != ""
@@ -169,6 +171,9 @@ config FW_LOADER_COMPRESS
          be compressed with either none or crc32 integrity check type (pass
          "-C crc32" option to xz command).
 
+         Compressed firmware support does not apply to firmware images
+         that are built into the kernel image (CONFIG_EXTRA_FIRMWARE).
+
 config FW_CACHE
        bool "Enable firmware caching during suspend"
        depends on PM_SLEEP