ovl: clarify ovl_get_root() semantics

Change the semantics to take a reference on upperdentry instead
of transferrig the reference.

This is needed for upcoming port to new mount api.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index ee9adb413d0e3abc361078322f10e88edfcc2ef5..280f2aa2f35684ef24cef18ca5bb7b9952890099 100644 (file)
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -1922,6 +1922,8 @@ static struct dentry *ovl_get_root(struct super_block *sb,
        ovl_set_upperdata(d_inode(root));
        ovl_inode_init(d_inode(root), &oip, ino, fsid);
        ovl_dentry_init_flags(root, upperdentry, oe, DCACHE_OP_WEAK_REVALIDATE);
+       /* root keeps a reference of upperdentry */
+       dget(upperdentry);
 
        return root;
 }
@@ -2100,7 +2102,7 @@ static int ovl_fill_super(struct super_block *sb, void *data, int silent)
        if (!root_dentry)
                goto out_free_oe;
 
-       mntput(upperpath.mnt);
+       path_put(&upperpath);
        kfree(splitlower);
 
        sb->s_root = root_dentry;