]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
remoteproc: imx_dsp_rproc: Use devm_rproc_add() helper
authorPeng Fan <peng.fan@nxp.com>
Wed, 19 Nov 2025 04:21:47 +0000 (12:21 +0800)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Wed, 19 Nov 2025 16:06:05 +0000 (09:06 -0700)
Replace manual rproc_add() and cleanup logic with devm_rproc_add(), which
ties the remoteproc lifecycle to the device's lifecycle. This simplifies
error handling and ensures proper cleanup.

No functional changes.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Tested-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20251119-imx-dsp-2025-11-19-v4-2-adafd342d07b@nxp.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/imx_dsp_rproc.c

index 1f7d15227ce4fad46ab4c6d71774cf0560b9529e..418bd3ac70a4aa294b89c5d646a89e4da5ad2c35 100644 (file)
@@ -1194,7 +1194,7 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev)
 
        init_completion(&priv->pm_comp);
        rproc->auto_boot = false;
-       ret = rproc_add(rproc);
+       ret = devm_rproc_add(dev, rproc);
        if (ret)
                return dev_err_probe(dev, ret, "rproc_add failed\n");
 
@@ -1207,10 +1207,7 @@ static int imx_dsp_rproc_probe(struct platform_device *pdev)
 
 static void imx_dsp_rproc_remove(struct platform_device *pdev)
 {
-       struct rproc *rproc = platform_get_drvdata(pdev);
-
        pm_runtime_disable(&pdev->dev);
-       rproc_del(rproc);
 }
 
 /* pm runtime functions */