]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amd/display: Initialize denominator defaults to 1
authorAlex Hung <alex.hung@amd.com>
Tue, 17 Dec 2024 18:51:58 +0000 (11:51 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 10 Jan 2025 18:42:26 +0000 (13:42 -0500)
[WHAT & HOW]
Variables, used as denominators and maybe not assigned to other values,
should be initialized to non-zero to avoid DIVIDE_BY_ZERO, as reported
by Coverity.

Reviewed-by: Austin Zheng <austin.zheng@amd.com>
Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit e2c4c6c10542ccfe4a0830bb6c9fd5b177b7bbb7)

drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c

index 601320b1be81717b201e1b24e00d3d81844e04ac..ecfa3c898e09dd837a1c590283a06aeea81bcc04 100644 (file)
@@ -579,8 +579,8 @@ static void CalculateBytePerPixelAndBlockSizes(
 {
        *BytePerPixelDETY = 0;
        *BytePerPixelDETC = 0;
-       *BytePerPixelY = 0;
-       *BytePerPixelC = 0;
+       *BytePerPixelY = 1;
+       *BytePerPixelC = 1;
 
        if (SourcePixelFormat == dml2_444_64) {
                *BytePerPixelDETY = 8;