- Fix #766: dns64 should synthesize results on timeout/errors.

git-svn-id: file:///svn/unbound/trunk@3721 be551aaa-1e26-0410-a405-d3ace91eadb9

diff --git a/dns64/dns64.c b/dns64/dns64.c
index 0de3f664334191f25bd1412ff32624b8485a4829..2fde67841bb39958b899333affe960a697856627 100644 (file)
--- a/dns64/dns64.c
+++ b/dns64/dns64.c
@@ -521,13 +521,14 @@ handle_event_moddone(struct module_qstate* qstate, int id)
      *   - An internal query.
      *   - A query for a record type other than AAAA.
      *   - CD FLAG was set on querier
-     *   - An AAAA query for which an error was returned.
+     *   - An AAAA query for which an error was returned.(qstate.return_rcode)
+     *     -> treated as servfail thus synthesize (sec 5.1.3 6147), thus
+     *        synthesize in (sec 5.1.2 of RFC6147).
      *   - A successful AAAA query with an answer.
      */
        if ( (enum dns64_qstate)qstate->minfo[id] == DNS64_INTERNAL_QUERY
             || qstate->qinfo.qtype != LDNS_RR_TYPE_AAAA
            || (qstate->query_flags & BIT_CD)
-           || qstate->return_rcode != LDNS_RCODE_NOERROR  
            || (qstate->return_msg &&
                    qstate->return_msg->rep &&
                    reply_find_answer_rrset(&qstate->qinfo,

diff --git a/doc/Changelog b/doc/Changelog
index cbc8c89705b53ef2b103cf4d009aa702891cb75b..0b50a169df10897510f94485307c3e130a48feb0 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,3 +1,6 @@
+19 May 2016: Wouter
+       - Fix #766: dns64 should synthesize results on timeout/errors.
+
 18 May 2016: Wouter
        - Fix #761: DNSSEC LAME false positive resolving nic.club.