]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: iwlwifi: mvm: Remove unused last_sub_index from reorder buffer
authorDaniel Gabay <daniel.gabay@intel.com>
Sun, 1 Sep 2024 04:17:56 +0000 (07:17 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 3 Sep 2024 09:55:27 +0000 (11:55 +0200)
The last_sub_index field is not used and appears to be a leftover
from a previous implementation, remove it.

Signed-off-by: Daniel Gabay <daniel.gabay@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20240901071542.da75cfef9144.I6e1fb635b2893618e6bd28501fb858042d8aa44e@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

index be637f6e407464ffed488d9324a3ed2a8ffe1124..650b562a22cde2de87ced16641721057c1e3432b 100644 (file)
@@ -774,7 +774,6 @@ struct iwl_mvm_tcm {
  * @num_stored: number of mpdus stored in the buffer
  * @queue: queue of this reorder buffer
  * @last_amsdu: track last ASMDU SN for duplication detection
- * @last_sub_index: track ASMDU sub frame index for duplication detection
  * @valid: reordering is valid for this queue
  * @lock: protect reorder buffer internal state
  */
@@ -783,7 +782,6 @@ struct iwl_mvm_reorder_buffer {
        u16 num_stored;
        int queue;
        u16 last_amsdu;
-       u8 last_sub_index;
        bool valid;
        spinlock_t lock;
 } ____cacheline_aligned_in_smp;
index ae0f2aabddc32d4ac1a2f0e38f21942a0b93886d..65f8933c34b420cdc75dc8ed4da98edea2106a9f 100644 (file)
@@ -729,8 +729,6 @@ static bool iwl_mvm_reorder(struct iwl_mvm *mvm,
        bool last_subframe =
                desc->amsdu_info & IWL_RX_MPDU_AMSDU_LAST_SUBFRAME;
        u8 tid = ieee80211_get_tid(hdr);
-       u8 sub_frame_idx = desc->amsdu_info &
-                          IWL_RX_MPDU_AMSDU_SUBFRAME_IDX_MASK;
        struct iwl_mvm_reorder_buf_entry *entries;
        u32 sta_mask;
        int index;
@@ -843,10 +841,8 @@ static bool iwl_mvm_reorder(struct iwl_mvm *mvm,
        __skb_queue_tail(&entries[index].frames, skb);
        buffer->num_stored++;
 
-       if (amsdu) {
+       if (amsdu)
                buffer->last_amsdu = sn;
-               buffer->last_sub_index = sub_frame_idx;
-       }
 
        /*
         * We cannot trust NSSN for AMSDU sub-frames that are not the last.