Silence compiler warnings from some older compilers.

Since a117cebd6, some older gcc versions issue "variable may be used
uninitialized in this function" complaints for brin_summarize_range.
Silence that using the same coding pattern as in bt_index_check_internal;
arguably, a117cebd6 had too narrow a view of which compilers might give
trouble.

Nathan Bossart and Tom Lane.  Back-patch as the previous commit was.

Discussion: https://postgr.es/m/20220601163537.GA2331988@nathanxps13

diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
index 31326ae8d2d9bd383fb58fecfa3cf7cbda427756..4c4ca02891f588a070cdb369852237f86abf4a2c 100644 (file)
--- a/contrib/amcheck/verify_nbtree.c
+++ b/contrib/amcheck/verify_nbtree.c
@@ -242,7 +242,7 @@ bt_index_check_internal(Oid indrelid, bool parentcheck, bool heapallindexed)
        else
        {
                heaprel = NULL;
-               /* for "gcc -Og" https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78394 */
+               /* Set these just to suppress "uninitialized variable" warnings */
                save_userid = InvalidOid;
                save_sec_context = -1;
                save_nestlevel = -1;

diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
index a39faf01003b011558828dbbb0f8a149e274073f..bb25ef8dc690f45db59de7223018495e221a95f2 100644 (file)
--- a/src/backend/access/brin/brin.c
+++ b/src/backend/access/brin/brin.c
@@ -916,7 +916,13 @@ brin_summarize_range(PG_FUNCTION_ARGS)
                save_nestlevel = NewGUCNestLevel();
        }
        else
+       {
                heapRel = NULL;
+               /* Set these just to suppress "uninitialized variable" warnings */
+               save_userid = InvalidOid;
+               save_sec_context = -1;
+               save_nestlevel = -1;
+       }
 
        indexRel = index_open(indexoid, ShareUpdateExclusiveLock);