]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mfd: sm501: Use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 7 Apr 2025 07:24:13 +0000 (09:24 +0200)
committerLee Jones <lee@kernel.org>
Fri, 23 May 2025 07:48:11 +0000 (08:48 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20250407-gpiochip-set-rv-mfd-v1-1-43f4d86d01d1@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/sm501.c

index 7ee293b09f628a632d24f59648a175eb462b3022..94ad18b52b83520256e5210d9beefe36db74f578 100644 (file)
@@ -915,7 +915,8 @@ static void sm501_gpio_ensure_gpio(struct sm501_gpio_chip *smchip,
        }
 }
 
-static void sm501_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static int sm501_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                         int value)
 
 {
        struct sm501_gpio_chip *smchip = gpiochip_get_data(chip);
@@ -939,6 +940,8 @@ static void sm501_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
        sm501_gpio_ensure_gpio(smchip, bit);
 
        spin_unlock_irqrestore(&smgpio->lock, save);
+
+       return 0;
 }
 
 static int sm501_gpio_input(struct gpio_chip *chip, unsigned offset)
@@ -1005,7 +1008,7 @@ static const struct gpio_chip gpio_chip_template = {
        .ngpio                  = 32,
        .direction_input        = sm501_gpio_input,
        .direction_output       = sm501_gpio_output,
-       .set                    = sm501_gpio_set,
+       .set_rv                 = sm501_gpio_set,
        .get                    = sm501_gpio_get,
 };